Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand detail page styling #62

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Brand detail page styling #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b146c35
Brand detail page styling ver1
JiangLong2019 Sep 20, 2023
77a17a3
Merge branch 'main' into issue-30
JiangLong2019 Sep 24, 2023
dd23fdd
Merge branch 'main' into issue-30
JiangLong2019 Oct 4, 2023
4576645
Bug fix
JiangLong2019 Oct 4, 2023
08b6452
Refactoring
JiangLong2019 Oct 5, 2023
500c306
Fix code check
JiangLong2019 Oct 5, 2023
4dcd8d1
Merge branch 'main' into issue-30
JiangLong2019 Oct 5, 2023
5285b15
Add visual test
JiangLong2019 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/visual-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types: [ opened, synchronize ]

env:
TEST_PATHS: "/ /career/yuya-yoshisue"
TEST_PATHS: "/ /career/yuya-yoshisue /brands/consumer-health-beauty"
TEST_PATHS_INDEXES: "/sidekick/library.json "
DOMAIN_MAIN: "main--sunstar--hlxsites.hlx.page"
DOMAIN_BRANCH: "${{github.head_ref}}--sunstar--hlxsites.hlx.page"
Expand Down
32 changes: 32 additions & 0 deletions blocks/image-collage/image-collage.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,22 @@ main .image-collage img {
width: calc(100vw - 2rem);
}

main .image-collage.wide img {
padding: 2.5rem 1rem;
}

main .image-collage.zoom-in img {
max-width: 10rem;
padding: unset;
margin-bottom: 0.5rem;
transform: scale(1);
}

main .image-collage.boxy-col-1.zoom-in::after {
content: unset;
flex: unset;
}

main .image-collage * {
font-size: var(--font-size-small);
color: #6D757C;
Expand Down Expand Up @@ -117,6 +133,22 @@ main div.autoblocked.image-collage[class*='boxy-col-'].caption-above.block > div
margin-bottom: 2rem;
}

main .image-collage.zoom-in img {
transform: scale(1.5);
}

main .image-collage.wide img {
padding: 2.5rem 1rem;
width: unset;
max-width: 100%;
box-sizing: border-box;
display: block;
}

main .image-collage.wide.boxy-col-1>div {
flex: unset;
}

main .image-collage[class*='boxy-col-']>div>div:first-of-type {
padding: unset;
}
Expand Down
1 change: 0 additions & 1 deletion blocks/link-dropdown/link-dropdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.link-dropdown.block {
max-width: 37.5rem;
margin: 3rem auto 0;
padding: 0 1rem;
}
Expand Down
3 changes: 2 additions & 1 deletion blocks/text/text.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ main .block.text.left-aligned h3,
main .block.text.left-aligned h4,
main .block.text.left-aligned h5,
main .block.text.left-aligned h6,
main .block.text.left-aligned p {
main .block.text.left-aligned p,
main .block.text.left-aligned div {
text-align: left;
margin-left: 0;
}
Expand Down
3 changes: 0 additions & 3 deletions styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,9 +771,6 @@ main .section.light-blue {
display: block;
}




/* START Section Styles START */

main .section .section-container {
Expand Down