issue-49 Tag Block Changes #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
1 task
jindaliiita
requested review from
bosschaert,
sdmcraft,
RitwikSrivastava and
hparwani2
|
|
bosschaert
approved these changes
Sep 24, 2023
|
|
Please add a visual test as described here. |
Will add this separately as currently i have added my draft file. |
If you add it to the block library (which is anyway needed for any new block) before the merge, that should suffice as it will automatically get tested (all blocks in library get tested). |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #49
Test URLs:
Original: https://www.sunstar.com
Before: https://main--sunstar--hlxsites.hlx.page/_drafts/piyush/healthy-thinking/how-has-covid-19-impacted-our-health
After: https://issue-49--sunstar--hlxsites.hlx.page/_drafts/piyush/healthy-thinking/how-has-covid-19-impacted-our-health
If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0