-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure tag page - change the logic of tag rendering #576
Conversation
|
@sdmcraft EDS doesn't support url parameters in redirect source URL, I'll try to find any other way to deal with it rather than redirects.xls
https://discord.com/channels/1131492224371277874/1207624789083168768/1207749171969265664 |
Changes looks fine to me |
If query parameter based redirects are not possible then how would we solve the original problem i.e. having the right canonical url on the page? |
After the change, each tag page owns correct canonical url now. The problem is that we wanted to redirect current site tag page to the new tag page, let's say, In redirects.xls, the source URL doesn't support URL with parameter, we cannot use redirects.xls for the redirection. In my opinion, I don't think it's necessary, maybe we can ignore it. |
@sdmcraft As we discussed, I've added the redirection for URL parameter tag page. Please have a check. |
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:
Issue
Fixes #575
Changelog:
Test URLs: