Targeted style to section-container #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
jindaliiita
reviewed
Dec 21, 2023
| @@ -1166,6 +1164,11 @@ main .section.with-background-image.align-top > .section-container, main .sectio | |||
| margin-bottom: 1rem; | |||
| } | |||
|
|
|||
| /* section - static */ | |||
| main .section.static > .section-container { | |||
There was a problem hiding this comment.
are we using static only at one place ?
There was a problem hiding this comment.
yes, that's what I found atleast through finder.
There was a problem hiding this comment.
Also similar observation with Sharepoint search. There's also a hero-banner(static) variant but likely that's not related to this change as this one is limiter to section level style.
|
Overall LGTM apart from one comment |
jindaliiita
approved these changes
Dec 21, 2023
ehrro
added a commit
to sunstar-global/sunstar
that referenced
this pull request
Jan 9, 2024
Targeted style to section-container (hlxsites#547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:
Issue
Fixes #546
Changelog:
Targeted style to section-container
Test URLs:
Library
New Blocks introduced in this PR
If yes, please provide details below
Block Name : For e.g. cards
Documented in sidekick library
New variations introduced in this PR
Variation Name : For e.g. cards (grid)
Documented in sidekick library
New mixins introduced in this PR
Mixin Name : For e.g. compact, white
Documented in sidekick library