Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing icons #539

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fixed missing icons #539

merged 2 commits into from
Dec 12, 2023

Conversation

dnbute
Copy link

@dnbute dnbute commented Dec 12, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:

Issue

Fixes #538

Changelog:

  • Added background image for missing icons
  • Changes some dimensions so icons don't get clipped

Test URLs:

Library

  • New Blocks introduced in this PR
    If yes, please provide details below
    Block Name : For e.g. cards

  • Documented in sidekick library

  • New variations introduced in this PR
    Variation Name : For e.g. cards (grid)

  • Documented in sidekick library

  • New mixins introduced in this PR
    Mixin Name : For e.g. compact, white

  • Documented in sidekick library

Copy link

aem-code-sync bot commented Dec 12, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 12, 2023

@dnbute dnbute requested review from sdmcraft and ehrro December 12, 2023 12:34
Copy link

@ehrro ehrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with sizing and alignment can you please enhance it? Thank you:
image

@dnbute
Copy link
Author

dnbute commented Dec 12, 2023

@ehrro should be better now 👍

@dnbute dnbute requested a review from ehrro December 12, 2023 13:13
@ehrro ehrro merged commit 1d00e1a into main Dec 12, 2023
4 checks passed
@ehrro ehrro deleted the i-538 branch December 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing arrow icons on buttons
2 participants