Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed padding for text #508

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Fixed padding for text #508

merged 4 commits into from
Dec 4, 2023

Conversation

dnbute
Copy link

@dnbute dnbute commented Dec 4, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:

Issue

Fixes #

Changelog:

  • align-top added

Test URLs:

Library

  • New Blocks introduced in this PR
    If yes, please provide details below
    Block Name : For e.g. cards

  • Documented in sidekick library

  • New variations introduced in this PR
    Variation Name : For e.g. cards (grid)

  • Documented in sidekick library

  • New mixins introduced in this PR
    Mixin Name : For e.g. compact, white

  • Documented in sidekick library

Copy link

aem-code-sync bot commented Dec 4, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 4, 2023

Page Scores Audits Google
/about/chairman-interview PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dnbute dnbute requested a review from ehrro December 4, 2023 12:00
@dnbute
Copy link
Author

dnbute commented Dec 4, 2023

@ehrro I also re-authored the page a bit, let me know if I should edit it in the sunstar sharepoint as well

@ehrro
Copy link

ehrro commented Dec 4, 2023

Hello @dnbute

On mobile it doesn't look good.

There is a top: 30% but there is also a translate property so it's not looking good.

Maybe we can set top: 0 padding-top: 1.5rem and remove the translate property on the container?

image

Thanks.

Copy link

@ehrro ehrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented earlier.

image

@dnbute dnbute requested a review from ehrro December 4, 2023 14:57
@ehrro
Copy link

ehrro commented Dec 4, 2023

Is it possible to create a padding variant on the block text? Because as you can see here we can't add padding to a lead variant otherwise it will break it:
image

@dnbute
Copy link
Author

dnbute commented Dec 4, 2023

@ehrro Yeah, my fault I didn't check, I assumed the lead variant had its own padding that would override this, I added a padded variant to text

Copy link

@ehrro ehrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ehrro ehrro merged commit b6dcad2 into main Dec 4, 2023
4 checks passed
@ehrro ehrro deleted the fix-lead branch December 4, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants