-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed padding for text #508
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
@ehrro I also re-authored the page a bit, let me know if I should edit it in the sunstar sharepoint as well |
Hello @dnbute On mobile it doesn't look good. There is a top: 30% but there is also a translate property so it's not looking good. Maybe we can set top: 0 padding-top: 1.5rem and remove the translate property on the container? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehrro Yeah, my fault I didn't check, I assumed the lead variant had its own padding that would override this, I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:
Issue
Fixes #
Changelog:
align-top
addedTest URLs:
Library
New Blocks introduced in this PR
If yes, please provide details below
Block Name : For e.g. cards
Documented in sidekick library
New variations introduced in this PR
Variation Name : For e.g. cards (grid)
Documented in sidekick library
New mixins introduced in this PR
Mixin Name : For e.g. compact, white
Documented in sidekick library