Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-469 async loading of breadcrumb content #488

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

jindaliiita
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:

Issue

Fixes #469

Changelog:

Please enter each change as a new bullet point

Test URLs:

Library

  • New Blocks introduced in this PR
    If yes, please provide details below
    Block Name : For e.g. cards

  • Documented in sidekick library

  • New variations introduced in this PR
    Variation Name : For e.g. cards (grid)

  • Documented in sidekick library

  • New mixins introduced in this PR
    Mixin Name : For e.g. compact, white

  • Documented in sidekick library

Copy link

aem-code-sync bot commented Nov 30, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/about/business-performance PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/about/business-performance PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@jindaliiita
Copy link
Author

@sdmcraft @dnbute can you please also check this once.

@hlxsites hlxsites deleted a comment from aem-code-sync bot Nov 30, 2023
Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/about/business-performance PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@jindaliiita jindaliiita merged commit 235e2b5 into main Nov 30, 2023
4 checks passed
@jindaliiita jindaliiita deleted the breadcrumb-fix branch November 30, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load breadcrumbs asynchronously
3 participants