Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Life with Sunstar page & columns refactor #212

Merged
merged 15 commits into from
Nov 1, 2023
Merged

Conversation

dnbute
Copy link

@dnbute dnbute commented Oct 25, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #

Changelog:

  • Added "autoblocking" tohero banner overlap so the text is on the right if it was authored in the right column
  • Added variant to invert even numbered columns in narrow view (as opposed to all the columns)
  • Added video modal support to columns if there is an appropriate anchor after the picture in the document
  • Refactored the columns block
  • Fixed bug with modals opening two videos

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@hlxsites hlxsites deleted a comment from github-actions bot Oct 27, 2023
@dnbute dnbute changed the title Life with Sunstar hero Life with Sunstar page Oct 27, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dnbute dnbute mentioned this pull request Oct 27, 2023
@dnbute dnbute changed the title Life with Sunstar page Life with Sunstar page & columns refactor Oct 27, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/about/life-with-sunstar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions
Copy link

🔸 7 visual differences detected

  • / (main vs branch)
    Expected an image 1280px by 4099px, received 1280px by 4056px. 395236 pixels (ratio 0.08 of all image pixels) are different.
  • /brands (main vs branch)
    Expected an image 1280px by 3735px, received 1280px by 3657px. 699819 pixels (ratio 0.15 of all image pixels) are different.
  • /about/history (main vs branch)
    Expected an image 1280px by 13448px, received 1280px by 14727px. 2062429 pixels (ratio 0.11 of all image pixels) are different.
  • /careers (main vs branch)
    Expected an image 1280px by 5995px, received 1280px by 5972px. 92246 pixels (ratio 0.02 of all image pixels) are different.
  • /healthy-thinking (main vs branch)
    Expected an image 1280px by 6097px, received 1280px by 6075px. 689438 pixels (ratio 0.09 of all image pixels) are different.
  • /sidekick/blocks/columns (main vs branch)
    Expected an image 1280px by 10880px, received 1280px by 10923px. 914739 pixels (ratio 0.07 of all image pixels) are different.
  • /sidekick/blocks/sections (main vs branch)
    Expected an image 1312px by 9152px, received 1312px by 9139px. 163624 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

@dnbute dnbute merged commit a4f7101 into main Nov 1, 2023
4 checks passed
@dnbute dnbute deleted the life-with-sunstar-hero branch November 1, 2023 08:21
@sdmcraft sdmcraft added this to the Milestone-7 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants