Image Captions #199
Merged
Image Captions #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
🔸 4 visual differences detected
The diff images are attached in the artifact |
|
🔸 5 visual differences detected
The diff images are attached in the artifact |
|
|
🔸 5 visual differences detected
The diff images are attached in the artifact |
|
@ehrro I also took the liberty of changing the muted text block color to match the captions, you can take a look at the business performance page to check that as well (FY 2020 for example, under the 2 piecharts) |
sdmcraft
reviewed
Oct 24, 2023
| @@ -150,7 +150,11 @@ export function splitChildDiv(div, from, to) { | |||
| } | |||
|
|
|||
| function buildImageCollageForPicture(picture, caption, buildBlockFunction) { | |||
| const newBlock = buildBlockFunction('image-collage', { elems: [picture, caption] }); | |||
| const captionText = caption.textContent; | |||
There was a problem hiding this comment.
Should you use innerHTML here instead of textContent to retain any HTML tags inside it.
There was a problem hiding this comment.
Well I want to get rid of the <em> tag so the captions aren't italic anymore, so i just need the actual text
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
ehrro
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #196
Changelog
Test URLs:
Original: https://www.sunstar.com/about/history
Before: https://main--sunstar--hlxsites.hlx.live/about/history
After: https://i-196--sunstar--hlxsites.hlx.live/about/history
Original: https://www.sunstar.com/about/business-performance
Before: https://main--sunstar--hlxsites.hlx.live/about/business-performance
After: https://i-196--sunstar--hlxsites.hlx.live/about/business-performance
If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0