Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust font styles #161

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Adjust font styles #161

merged 1 commit into from
Oct 18, 2023

Conversation

sdmcraft
Copy link

@sdmcraft sdmcraft commented Oct 17, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #142

Test URLs:

@sdmcraft sdmcraft requested a review from ehrro October 17, 2023 09:01
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions
Copy link

🔸 10 visual differences detected

  • /healthy-thinking/6-things-you-didnt-know-about-your-oral-health (main vs branch)
    Expected an image 1280px by 3668px, received 1280px by 3663px. 53556 pixels (ratio 0.02 of all image pixels) are different.
  • / (main vs branch)
    214720 pixels (ratio 0.05 of all image pixels) are different.
  • /brands/consumer-health-beauty (main vs branch)
    Expected an image 1280px by 4011px, received 1280px by 4000px. 158170 pixels (ratio 0.04 of all image pixels) are different.
  • /about/history (main vs branch)
    Expected an image 1280px by 13702px, received 1280px by 13692px. 529037 pixels (ratio 0.04 of all image pixels) are different.
  • /about/business-performance (main vs branch)
    Expected an image 1280px by 2991px, received 1280px by 2971px. 273402 pixels (ratio 0.08 of all image pixels) are different.
  • /sidekick/blocks/text-image (main vs branch)
    Expected an image 1280px by 4124px, received 1280px by 4108px. 63248 pixels (ratio 0.02 of all image pixels) are different.
  • /sidekick/blocks/tables (main vs branch)
    Expected an image 1280px by 2025px, received 1280px by 2004px.
  • /sidekick/blocks/sections (main vs branch)
    Expected an image 1312px by 7432px, received 1312px by 7407px. 391737 pixels (ratio 0.05 of all image pixels) are different.
  • /sidekick/blocks/network-item (main vs branch)
    Expected an image 1280px by 1781px, received 1280px by 1749px. 102854 pixels (ratio 0.05 of all image pixels) are different.
  • /sidekick/blocks/fragment (main vs branch)
    Expected an image 1280px by 799px, received 1280px by 794px. 23261 pixels (ratio 0.03 of all image pixels) are different.

The diff images are attached in the artifact

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 18, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sdmcraft sdmcraft merged commit 42a2c90 into main Oct 18, 2023
4 checks passed
@sdmcraft sdmcraft deleted the i-142 branch October 18, 2023 06:38
@sdmcraft sdmcraft modified the milestones: Milestone-6, Milestone-5 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update font variable --heading-font-size-m and --heading-font-size-s
2 participants