Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial history column #115

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Added initial history column #115

merged 5 commits into from
Oct 9, 2023

Conversation

dnbute
Copy link

@dnbute dnbute commented Oct 9, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #116

  • Added history column variation

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync

This comment was marked as resolved.

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/_drafts/dbute/toc/toc PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/_drafts/dbute/toc/toc PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🔸 1 visual difference detected

  • / (main vs branch)
    410141 pixels (ratio 0.08 of all image pixels) are different.

The diff images are attached in the artifact

@dnbute
Copy link
Author

dnbute commented Oct 9, 2023

🔸 1 visual difference detected

  • / (main vs branch)410141 pixels (ratio 0.08 of all image pixels) are different.

The diff images are attached in the artifact

Seem pretty identical to me on the actual pages

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/_drafts/dbute/toc/toc PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@bosschaert bosschaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/_drafts/dbute/toc/toc PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync

This comment was marked as outdated.

1 similar comment
@aem-code-sync

This comment was marked as off-topic.

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/_drafts/dbute/toc/toc PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dnbute dnbute merged commit 594e715 into main Oct 9, 2023
4 checks passed
@dnbute dnbute deleted the history-block branch October 9, 2023 11:46
@sdmcraft sdmcraft added this to the Milestone-4 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add history block/block variant
3 participants