-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Block Variant - General added, Changes wrt to caption and importer #110
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
Nit: ① In the original site, when someone clicks the social icon, it jumps to the social site in the same window rather than opening a new window. ② the space between icons is a little bit bigger than the original one. ③ Lost icon animation(shows bigger) when mouseovers it. |
🔸 1 visual difference detected
The diff images are attached in the artifact |
Thank @JiangLong2019, resolved all the above comments. Also regarding social site opening in new window, i have maintained the consistency which we are following across website to open external links in news window. |
@jindaliiita Thanks, looks good to me. |
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes
Test URLs:
Original: https://www.sunstar.com/healthy-thinking/firefighters-at-sunstar-hq-building
Before: https://main--sunstar--hlxsites.hlx.live/healthy-thinking/firefighters-at-sunstar-hq-building
After: https://healthy-importer--sunstar--hlxsites.hlx.live/healthy-thinking/firefighters-at-sunstar-hq-building
Original: https://www.sunstar.com/healthy-thinking/cpc-containing-mouthwash-inactivates-coronavirus-scientific-research
Before: https://main--sunstar--hlxsites.hlx.live/healthy-thinking/cpc-containing-mouthwash-inactivates-coronavirus-scientific-research
After: https://healthy-importer--sunstar--hlxsites.hlx.live/healthy-thinking/cpc-containing-mouthwash-inactivates-coronavirus-scientific-research
If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0