Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Block Variant - General added, Changes wrt to caption and importer #110

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

jindaliiita
Copy link

@jindaliiita jindaliiita commented Oct 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 7, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@hlxsites hlxsites deleted a comment from aem-code-sync bot Oct 7, 2023
@hlxsites hlxsites deleted a comment from aem-code-sync bot Oct 7, 2023
@hlxsites hlxsites deleted a comment from aem-code-sync bot Oct 7, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 7, 2023

Page Scores Audits Google
/healthy-thinking/firefighters-at-sunstar-hq-building PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 8, 2023

Page Scores Audits Google
/healthy-thinking/firefighters-at-sunstar-hq-building PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@jindaliiita jindaliiita changed the title Changes wrt to caption and importer Social Block Variant - General added, Changes wrt to caption and importer Oct 8, 2023
@JiangLong2019
Copy link

Nit:

① In the original site, when someone clicks the social icon, it jumps to the social site in the same window rather than opening a new window.

② the space between icons is a little bit bigger than the original one.

Original:
image

Franklin:
image

③ Lost icon animation(shows bigger) when mouseovers it.

Original:
image

Franklin:
image

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

🔸 1 visual difference detected

  • /brands/consumer-health-beauty (main vs branch)
    Expected an image 1280px by 4109px, received 1280px by 4101px. 159615 pixels (ratio 0.04 of all image pixels) are different.

The diff images are attached in the artifact

@jindaliiita
Copy link
Author

Nit:

① In the original site, when someone clicks the social icon, it jumps to the social site in the same window rather than opening a new window.

② the space between icons is a little bit bigger than the original one.

Original: image

Franklin: image

③ Lost icon animation(shows bigger) when mouseovers it.

Original: image

Franklin: image

Thank @JiangLong2019, resolved all the above comments. Also regarding social site opening in new window, i have maintained the consistency which we are following across website to open external links in news window.

@JiangLong2019
Copy link

@jindaliiita Thanks, looks good to me.

@jindaliiita jindaliiita merged commit 1191bb4 into main Oct 9, 2023
4 checks passed
@jindaliiita jindaliiita deleted the healthy-importer branch October 9, 2023 02:56
@sdmcraft sdmcraft added this to the Milestone-4 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants