Refactor TOC to support anchor specified in metadata #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
dnbute
reviewed
Oct 5, 2023
| tocIndex = i; | ||
| } | ||
|
|
||
| [...ul.querySelectorAll('li')].forEach((li) => { |
There was a problem hiding this comment.
Could this also be implemented for the side TOC as well to maintain consistency?
There was a problem hiding this comment.
@dnbute Unfortunately I don't have this needs for current page. If you have we can do it, or we can do it in the future.
sdmcraft
approved these changes
Oct 6, 2023
blocks/toc/toc.js
Outdated
| li.innerText = ''; | ||
| li.append(aLink); | ||
| }); | ||
| [...document.querySelectorAll('[data-toc]')].forEach((section) => { |
There was a problem hiding this comment.
Nit: Maybe I'd rename the property toc to toc-anchor to convey the meaning.
|
It'd be great if you can add an example for this in the block library. Please ignore if done already. |
|
|
All done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #100
Test URLs:
Original: https://www.sunstar.com/brands/consumer-health-beauty/
Before: https://main--sunstar--hlxsites.hlx.live/brands/consumer-health-beauty
After: https://issue-100--sunstar--hlxsites.hlx.live/brands/consumer-health-beauty
If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0