Feed and Card Block Changes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
🔸 1 visual difference detected
The diff images are attached in the artifact |
|
jindaliiita
requested review from
bosschaert,
sdmcraft,
dnbute,
hparwani2 and
JiangLong2019
dnbute
reviewed
Oct 5, 2023
|
🔸 1 visual difference detected
The diff images are attached in the artifact |
|
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
🔸 2 visual differences detected
The diff images are attached in the artifact |
bosschaert
reviewed
Oct 5, 2023
bosschaert
reviewed
Oct 5, 2023
bosschaert
reviewed
Oct 5, 2023
bosschaert
reviewed
Oct 5, 2023
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
sdmcraft
reviewed
Oct 5, 2023
styles/styles.css
Outdated
| @@ -716,6 +716,10 @@ main .section.light-blue { | |||
| background-color: var(--transparent-blue-light-color); | |||
| } | |||
|
|
|||
| main .section.no-padding .section-container { | |||
| padding: 0; | |||
There was a problem hiding this comment.
Is this needed? I think all section-containers must have same styling unless there's a special case to handle.
There was a problem hiding this comment.
Needed for tablet view (cards block)
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
sdmcraft
approved these changes
Oct 6, 2023
|
Please add examples of the "related" in the block library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #
Test URLs:
Original: https://www.sunstar.com/healthy-thinking/6-things-you-didnt-know-about-your-oral-health
Before: https://main--sunstar--hlxsites.hlx.live/healthy-thinking/6-things-you-didnt-know-about-your-oral-health
After: https://feed-changes--sunstar--hlxsites.hlx.live/healthy-thinking/6-things-you-didnt-know-about-your-oral-health
If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0