Skip to content

Commit

Permalink
Fix rendering of icon on social career button
Browse files Browse the repository at this point in the history
  • Loading branch information
bosschaert committed Sep 20, 2023
1 parent 9cac667 commit 0dbdae4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
5 changes: 0 additions & 5 deletions blocks/career-apply/career-apply.css
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@
width: 2.125rem;
}

.career-apply span.icon-linkedin svg {
/* This is needed as otherwise the icon is shown twice */
display: none;
}

@media (min-width: 62rem) {
.career-apply {
max-width: 45rem;
Expand Down
3 changes: 1 addition & 2 deletions blocks/career-apply/career-apply.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getLanguage } from '../../scripts/scripts.js';
import { decorateIcons, fetchPlaceholders } from '../../scripts/lib-franklin.js';
import { fetchPlaceholders } from '../../scripts/lib-franklin.js';

export default async function decorate(block) {
const placeholders = await fetchPlaceholders(getLanguage());
Expand Down Expand Up @@ -32,7 +32,6 @@ export default async function decorate(block) {
const sprite = document.createElement('span');
sprite.classList.add('icon', 'icon-linkedin');
linkedin.appendChild(sprite);
decorateIcons(linkedin);
buttonBar.append(linkedin);
block.appendChild(buttonBar);
}

0 comments on commit 0dbdae4

Please sign in to comment.