Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load GetFeedback script #249

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Load GetFeedback script #249

merged 6 commits into from
Dec 10, 2024

Conversation

iansk
Copy link
Collaborator

@iansk iansk commented Nov 8, 2024

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 8, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 8, 2024 •
edited
Loading

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Escape backslashes in GetFeedback tag
06cbb72 
The backslash is being interpreted by the code that reads the string, rather than being passed to the regular expression parser.
@iansk iansk merged commit 5ef3336 into main Dec 10, 2024
2 checks passed
@iansk iansk deleted the ian-getfeedback branch December 10, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iansk