Add ToC filter #241
Merged
Add ToC filter #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 21, 2024 02:50
- Show the TOC filter in the left nav. - Fix the logic that filters topics.
Update the sidenav search-toc CSS to: - Show the filter icon as a background image in the input box. - Hide the background image when you start typing in the input box. - Indent the placeholder text with padding so it doesn't overlap with the filter icon.
At this point, I've got two options: - Implement a more complex filter control - Implement a very simple filter control. I want to implement both, test both, and then determine the best path forward. Simple might be better for the mobile experience.
With the new filter control now taking up vertical space in the sidenav, tweak the value for max-height for .toc-books (the container that holds all the nav book/article links).
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
@maxakuru Can you please review my PR? Thanks! |
|
@maxakuru Thanks for your review. Merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrect the ToC filter control in the sidenav (with fixes and tweaks).
Test URLs: