Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Adobe Launch #240

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add Adobe Launch #240

merged 2 commits into from
Apr 19, 2024

Conversation

iansk
Copy link
Collaborator

@iansk iansk commented Apr 16, 2024

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 16, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 16, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@iansk
Copy link
Collaborator Author

iansk commented Apr 16, 2024

@maxakuru Could you please review my PR?

I pulled the loadScript() function from the newer aem.js script.

@iansk iansk requested a review from maxakuru April 16, 2024 16:14
maxakuru
maxakuru approved these changes Apr 17, 2024
View reviewed changes
scripts/delayed.js Outdated Show resolved Hide resolved
@iansk iansk merged commit 0a16234 into main Apr 19, 2024
1 of 2 checks passed
@iansk iansk deleted the ian-analytics-phase1 branch April 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxakuru maxakuru maxakuru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iansk @maxakuru