Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable language selector for now #234

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: disable language selector for now #234

merged 1 commit into from
Nov 13, 2023

Conversation

maxakuru
Copy link
Contributor

  • adds toggle constant for language selector element in scripts.js, set to false for now

Test URLs:

@maxakuru maxakuru requested a review from iansk November 13, 2023 20:03
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 13, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 13, 2023

Page Scores Audits Google
/en PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@iansk
Copy link
Collaborator

iansk commented Nov 13, 2023

Thanks @maxakuru. That's a nice fix. Merging this now.

@iansk iansk merged commit 1036b22 into main Nov 13, 2023
2 checks passed
@iansk iansk deleted the maxed/lang-selector branch November 13, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansk iansk iansk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxakuru @iansk