Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: experimentation plugin version increment #577

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

iamtarun99
Copy link
Collaborator

@iamtarun99 iamtarun99 commented Apr 11, 2024

ramboz and others added 15 commits February 28, 2024 08:32
Co-authored-by: ivanviviani <[email protected]>
Co-authored-by: Julien Ramboz <[email protected]>
If the author or content source sets a path only we have to provide a
base URL to construct a new URL.

This is the default for AEM Authoring with Edge Delivery Services as we
will maintain the variants meta data as path and not as absolute URL.
…a8b1b523f64a01c'

git-subtree-dir: plugins/experimentation
git-subtree-mainline: c8d6c4a
git-subtree-split: f54a6ca
3814bb9 fix: code only variants cause regression in regular variants parsing
54c17e5 feat: add support for code-only experiments
6f33207 fix: variants are not properly decorated

git-subtree-dir: plugins/experimentation
git-subtree-split: 3814bb9c78e2885f5e49367c076630f360560b05
@iamtarun99 iamtarun99 requested a review from ramboz April 11, 2024 16:52
@iamtarun99 iamtarun99 self-assigned this Apr 11, 2024
Copy link

aem-code-sync bot commented Apr 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 11, 2024

Page Scores Audits Google
/us/en/drafts/exp20990/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@solaris007
Copy link
Contributor

@iamtarun99 is the drop in performance to 92 unavoidable?

@ramboz
Copy link
Contributor

ramboz commented Apr 19, 2024

@solaris007 It's against a hlx.page since it's on a draft page… the perf on a hlx.live site will be higher

@solaris007
Copy link
Contributor

@ramboz the PR template always pointed to .page and we always endeavored for getting close to 100 in these circumstances. are you saying we should make an exception due to experimentation's specificity?

@ramboz
Copy link
Contributor

ramboz commented Apr 23, 2024

@solaris007 My point is that .hlx.page doesn't do the caching, so you have quite a bit of variance in the PageSpeed tests. A test against .hlx.live will be more stable and representative of the end user experience (CrUX).
The AEM boilerplate was updated a while back accordingly in adobe/aem-boilerplate@158e5c7 to address adobe/aem-boilerplate#269

On top of that, the experimentation engine does indeed impact the SI on the preview pages because it injects its overlay pill at the end of the lazy phase. So the initial viewport sees a late repaint which pushes the SI quite late.
If you are unhappy with the SI on preview pages, you would have 2 options:

  • instrument the lazy phase of the plugin earlier
  • add a query parameter flag to disable the UI for the tests

@solaris007
Copy link
Contributor

@iamtarun99 @ramboz mind that mammotome is now on helix 5, including config service. i have merged main and adjusted the test URLs.

@solaris007 solaris007 self-requested a review April 24, 2024 05:24
@solaris007 solaris007 changed the title JIRA-20990 Experimentation plugin version increment chore: experimentation plugin version increment Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants