Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating image design 1 #261

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Floating image design 1 #261

merged 4 commits into from
Aug 8, 2024

Conversation

jindaliiita
Copy link
Collaborator

@jindaliiita jindaliiita commented Jul 26, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix

Test URLs:

Copy link

aem-code-sync bot commented Jul 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 26, 2024

Page Scores Audits Google
/drafts/piyush/floating-image PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to floating-image July 26, 2024 17:20 Inactive
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its necessary to separate out the CSS for the Agent template design - or if you do, just import it in the root floating-images.css; dynamically loading it isn't necessary

@jindaliiita
Copy link
Collaborator Author

I don't think its necessary to separate out the CSS for the Agent template design - or if you do, just import it in the root floating-images.css; dynamically loading it isn't necessary

We maintained separate files to ensure readability. Additionally, there will be multiple designs, but only one will load at a time, ultimately saving bytes over the network.

@aem-code-sync aem-code-sync bot temporarily deployed to floating-image July 31, 2024 05:26 Inactive
@jindaliiita jindaliiita merged commit 122e873 into main Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants