Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent Profile Design 1 changes #258

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Agent Profile Design 1 changes #258

merged 4 commits into from
Aug 9, 2024

Conversation

jindaliiita
Copy link
Collaborator

@jindaliiita jindaliiita commented Jul 25, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 25, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to agent-profile-design-1 July 25, 2024 05:05 Inactive
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 25, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/piyush/agent-profile PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

bstopp
bstopp requested changes Jul 29, 2024
View reviewed changes
scripts/util.js Outdated Show resolved Hide resolved
blocks/agent-profile/agent-profile.js Outdated Show resolved Hide resolved
@jindaliiita jindaliiita force-pushed the agent-profile-design-1 branch from 1027679 to e1b7600 Compare August 8, 2024 06:41
@jindaliiita jindaliiita requested a review from bstopp August 8, 2024 06:45
@hlxsites hlxsites deleted a comment from aem-code-sync bot Aug 8, 2024
bstopp
bstopp previously approved these changes Aug 8, 2024
View reviewed changes
@jindaliiita jindaliiita force-pushed the agent-profile-design-1 branch from 756e006 to 933eeeb Compare August 8, 2024 16:45
@jindaliiita jindaliiita merged commit 5f01134 into main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitwikSrivastava RitwikSrivastava RitwikSrivastava approved these changes

@bstopp bstopp bstopp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jindaliiita @bstopp @RitwikSrivastava