Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Hero Option #193

Merged
merged 7 commits into from
May 21, 2024
Merged

Video Hero Option #193

merged 7 commits into from
May 21, 2024

Conversation

rrusher
Copy link
Collaborator

@rrusher rrusher commented Jan 19, 2024

Copy link

aem-code-sync bot commented Jan 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 19, 2024

Page Scores Audits Google
/drafts/rrusher/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rrusher rrusher requested a review from bstopp January 19, 2024 23:00
@rrusher rrusher self-assigned this Jan 19, 2024
@rrusher rrusher requested a review from badvision January 19, 2024 23:02
@aem-code-sync aem-code-sync bot temporarily deployed to 165-video-hero April 2, 2024 13:30 Inactive
@bstopp
Copy link
Collaborator

bstopp commented Apr 2, 2024

The video seems to be lower quality - is this the same as the one on the live site? Or has it been modified by the AEM Edge Delivery backend?

Also, it doesn't seem to auto-play on FireFox

@bstopp
Copy link
Collaborator

bstopp commented Apr 25, 2024

Can you sync this up with the changes we got for design updates?

@aem-code-sync aem-code-sync bot temporarily deployed to 165-video-hero May 20, 2024 20:56 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 165-video-hero May 20, 2024 21:04 Inactive
bstopp
bstopp previously approved these changes May 20, 2024
Copy link
Collaborator

@badvision badvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY!

blocks/hero/hero.js Outdated Show resolved Hide resolved
@bstopp bstopp merged commit 0d4d91c into main May 21, 2024
2 checks passed
@bstopp bstopp deleted the 165-video-hero branch May 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hero v/ Video
3 participants