Feat/login2 #190
Merged
Feat/login2 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 11, 2024 14:47
…acking for logged in user
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
bstopp
reviewed
Jan 18, 2024
scripts/apis/user.js
Outdated
| }).toString(), | ||
| }); | ||
| if (resp.ok) { | ||
| console.log('Success!'); |
There was a problem hiding this comment.
I can remove console logging.
bstopp
reviewed
Jan 18, 2024
scripts/apis/user.js
Outdated
| sessionStorage.setItem('userDetails', JSON.stringify(sessionData)); | ||
| return sessionData; | ||
| } | ||
| console.error('Failed to login'); |
bstopp
approved these changes
Jan 18, 2024
bstopp
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Cherry-pick feat/login changes * Fix JS errors * Missing from merge * Missed in the merge * Adding delay logic to load the delayed part of the form * Added more utility functions around login/logout and session state tracking for logged in user * treat invalid login as a logout as well * More login handling of errors, fetching profile, and showing user name in navigation * Remove external ID from initial login * Handle logged-in user on page load * Fix lint issue * Remove console logging --------- Co-authored-by: Brendan Robert <[email protected]>
bstopp
added a commit
that referenced
this pull request
May 20, 2024
* Some improvements to loading and Accessibility. * Fix icons. * More icon fixing. * Need to test intermediate logic on site. * Remove references to partytown. (#178) * add style for section top-border (#179) Co-authored-by: Bryan Stopp <[email protected]> * added style to override margin bottom (#180) Co-authored-by: Bryan Stopp <[email protected]> * update host for dev publishing (#182) * starter hero slides * mocked listings * Fix images in default content. (#184) * fix the gradiant overlay, less opacity (#185) * Update styles on Shade Icon card variation. (#186) * css layout * hide paging * rearrange functions * disable linting on specific functions * css linting * style updates * added class that scales images * js linting * added section full-bleed to allow full-witdh scaled image * create div for headline * add row for headline to block * js clean up * linting * linting * linting css * js linting * update logic around classlist * create helix-query and start lookahead dropdown * display list w/ listeners * css tune * css clean up * js clean up * js update * js linting * css linting * css linting color notation * add communities search styles * Feat/login2 (#190) * Cherry-pick feat/login changes * Fix JS errors * Missing from merge * Missed in the merge * Adding delay logic to load the delayed part of the form * Added more utility functions around login/logout and session state tracking for logged in user * treat invalid login as a logout as well * More login handling of errors, fetching profile, and showing user name in navigation * Remove external ID from initial login * Handle logged-in user on page load * Fix lint issue * Remove console logging --------- Co-authored-by: Brendan Robert <[email protected]> * add style to adjust hero brightness in community dir * Adjusted the city text and styling * add braces * css linting * Feat/profile (#194) * Update profile code implemetation * Start of profile UI implementation and saving routine * Tabs are working, needs more form styling and validation though * Style improvements, also adjusted selectors to make linter happy * Dropdown values implemented * More styling work and visual support for required fields * Updated form placeholders to match site * Remove empty selections for regional preferences * Skip missing profile check * Improvements to error reporting and form submission. * Profile saves working! * Password reset working * Navigation and login/logout starting to work. Needs more testing * Small cleanup * Fix linting gripes * Better session handling and also moved header visibility changes into header block (and out of login-delayed) * Refactored i18n to be in utils * Add i18n support to header nav * Added i18n to login form * Add i18n to login form * Missing two text strings in i18n for login --------- Co-authored-by: Brendan Robert <[email protected]> * Intermediate work. * Intermediate work with property search bar refactor. * Final work for updating Property Search Bar. * Fix some lint. * Functional Search results list. * Functional Search results list. * Add pagination and all associated logic. * Intermediate work on map. * Intermediate info window work. * More intermediate pin work. * Finalize info window views. * Finish mapping logic. * Push first search off til after CWV * No redraw on pagination. * Trying css based animation. * Fix some minor visual bugs. --------- Co-authored-by: Rob Rusher <[email protected]> Co-authored-by: Rob Rusher <[email protected]> Co-authored-by: Brendan Robert <[email protected]> Co-authored-by: Brendan Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements username/password login with showing the login name on the header.
Some other utility functions for getting user profile and login status, logout are also implemented.
Fix #152
Test URLs: