Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust footer spacing #180

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Adjust footer spacing #180

merged 2 commits into from
Dec 6, 2023

Conversation

rrusher
Copy link
Collaborator

@rrusher rrusher commented Dec 4, 2023

@rrusher rrusher self-assigned this Dec 4, 2023
Copy link

aem-code-sync bot commented Dec 4, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@rrusher rrusher requested a review from bstopp December 4, 2023 22:27
Copy link

aem-code-sync bot commented Dec 4, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bstopp bstopp merged commit d0f3852 into main Dec 6, 2023
2 checks passed
@bstopp bstopp deleted the 146-footer-spacing branch December 6, 2023 14:52
badvision pushed a commit that referenced this pull request Jan 10, 2024
bstopp added a commit that referenced this pull request Mar 6, 2024
bstopp added a commit that referenced this pull request May 20, 2024
* Some improvements to loading and Accessibility.

* Fix icons.

* More icon fixing.

* Need to test intermediate logic on site.

* Remove references to partytown. (#178)

* add style for section top-border (#179)

Co-authored-by: Bryan Stopp <[email protected]>

* added style to override margin bottom (#180)

Co-authored-by: Bryan Stopp <[email protected]>

* update host for dev publishing (#182)

* starter hero slides

* mocked listings

* Fix images in default content. (#184)

* fix the gradiant overlay, less opacity (#185)

* Update styles on Shade Icon card variation. (#186)

* css layout

* hide paging

* rearrange functions

* disable linting on specific functions

* css linting

* style updates

* added class that scales images

* js linting

* added section full-bleed to allow full-witdh scaled image

* create div for headline

* add row for headline to block

* js clean up

* linting

* linting

* linting css

* js linting

* update logic around classlist

* create helix-query and start lookahead dropdown

* display list w/ listeners

* css tune

* css clean up

* js clean up

* js update

* js linting

* css linting

* css linting color notation

* add communities search styles

* Feat/login2 (#190)

* Cherry-pick feat/login changes

* Fix JS errors

* Missing from merge

* Missed in the merge

* Adding delay logic to load the delayed part of the form

* Added more utility functions around login/logout and session state tracking for logged in user

* treat invalid login as a logout as well

* More login handling of errors, fetching profile, and showing user name in navigation

* Remove external ID from initial login

* Handle logged-in user on page load

* Fix lint issue

* Remove console logging

---------

Co-authored-by: Brendan Robert <[email protected]>

* add style to adjust hero brightness in community dir

* Adjusted the city text and styling

* add braces

* css linting

* Feat/profile (#194)

* Update profile code implemetation

* Start of profile UI implementation and saving routine

* Tabs are working, needs more form styling and validation though

* Style improvements, also adjusted selectors to make linter happy

* Dropdown values implemented

* More styling work and visual support for required fields

* Updated form placeholders to match site

* Remove empty selections for regional preferences

* Skip missing profile check

* Improvements to error reporting and form submission.

* Profile saves working!

* Password reset working

* Navigation and login/logout starting to work.  Needs more testing

* Small cleanup

* Fix linting gripes

* Better session handling and also moved header visibility changes into header block (and out of login-delayed)

* Refactored i18n to be in utils

* Add i18n support to header nav

* Added i18n to login form

* Add i18n to login form

* Missing two text strings in i18n for login

---------

Co-authored-by: Brendan Robert <[email protected]>

* Intermediate work.

* Intermediate work with property search bar refactor.

* Final work for updating Property Search Bar.

* Fix some lint.

* Functional Search results list.

* Functional Search results list.

* Add pagination and all associated logic.

* Intermediate work on map.

* Intermediate info window work.

* More intermediate pin work.

* Finalize info window views.

* Finish mapping logic.

* Push first search off til after CWV

* No redraw on pagination.

* Trying css based animation.

* Fix some minor visual bugs.

---------

Co-authored-by: Rob Rusher <[email protected]>
Co-authored-by: Rob Rusher <[email protected]>
Co-authored-by: Brendan Robert <[email protected]>
Co-authored-by: Brendan Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer spacing should be adjusted
2 participants