Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards block variant for Shade Icon #172

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Cards block variant for Shade Icon #172

merged 5 commits into from
Dec 1, 2023

Conversation

rrusher
Copy link
Collaborator

@rrusher rrusher commented Nov 8, 2023

Cards (shade-icon):
Add styles to display cards with icons and shaded background.

Fix #124

Test URLs:

@rrusher rrusher self-assigned this Nov 8, 2023
Copy link

aem-code-sync bot commented Nov 8, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Nov 8, 2023

Page Scores Audits Google
/drafts/cards Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@rrusher rrusher requested a review from bstopp November 9, 2023 18:28
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/drafts/cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Dec 1, 2023

Page Scores Audits Google
/drafts/cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Dec 1, 2023

Page Scores Audits Google
/drafts/cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bstopp bstopp merged commit b95687f into main Dec 1, 2023
2 checks passed
@bstopp bstopp deleted the cards-shade-icon branch December 1, 2023 20:17
badvision pushed a commit that referenced this pull request Jan 10, 2024
* add styles for variant

* add icons

* add space below card for this variant

---------

Co-authored-by: Bryan Stopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Shade Icon" card variation
2 participants