#464411 - code cleanup

hlxsites · May 28, 2024 · c718c5d · c718c5d
1 parent 53219e1
commit c718c5d
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/blocks/section-metadata/section-metadata.js b/blocks/section-metadata/section-metadata.js
@@ -1,4 +1,3 @@
-// import { collectAttributes } from '../../scripts/libs.js';
 import ComponentBase from '../../scripts/component-base.js';
 import { stringToArray } from '../../scripts/libs.js';
 

diff --git a/scripts/component-base.js b/scripts/component-base.js
@@ -114,8 +114,7 @@ export default class ComponentBase extends HTMLElement {
         configByClasses,
         this.Handler.observedAttributes,
       );
-      // this.componentName ??= componentName;
-      this.webComponentName ??= this.initOptions.webComponentName;
+
       this.mergeConfigs();
       this.setAttributesClassesAndProps();
       this.addDefaultsToNestedConfig();

diff --git a/scripts/component-loader.js b/scripts/component-loader.js
@@ -5,7 +5,7 @@ export default class ComponentLoader {
     componentName,
     targets = [],
     loaderConfig,
-    configByClasses, // To be replaced with `attributesValues`
+    configByClasses,
     attributesValues,
     externalConfigName,
     componentConfig,

diff --git a/scripts/libs.js b/scripts/libs.js
@@ -326,7 +326,6 @@ export const configFromClasses = {
 
       if (isBreakpoint) value = value.slice(classBreakpoint.length + 1);
 
-      // this should be done outside and run through the methods
       const componentName = nestedComponentsNames.find((prefix) => value.startsWith(prefix));
       if (componentName) {
         acc[componentName] ??= { componentName, active: true };