#461424 #461425 - Code cleanup

hlxsites · Apr 22, 2024 · 32cb4ac · 32cb4ac
1 parent 1a8d90a
commit 32cb4ac
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 22 deletions.
diff --git a/blocks/accordion/accordion.js b/blocks/accordion/accordion.js
@@ -3,22 +3,19 @@ import ComponentBase from '../../scripts/component-base.js';
 export default class Accordion extends ComponentBase {
   dependencies = ['icon'];
 
-  // extendNestedConfig() {
-  //   return [
-  //     ...super.extendNestedConfig(),
-  //     {
-  //       button: {
-  //         componentName: 'button',
-  //         // active: false,
-  //         loaderConfig: {
-  //           targetsSelectorsPrefix: ':not(.accordion-control) >',
-  //         },
-  //       },
-  //     },
-  //   ];
-  // }
-
-  // nestedComponentsConfig = {};
+  extendNestedConfig() {
+    return [
+      ...super.extendNestedConfig(),
+      {
+        button: {
+          componentName: 'button',
+          loaderConfig: {
+            targetsSelectorsPrefix: ':scope > :is(:nth-child(even)) >',
+          },
+        },
+      },
+    ];
+  }
 
   ready() {
     this.setAttribute('role', 'navigation');

diff --git a/blocks/button/button.js b/blocks/button/button.js
@@ -6,8 +6,16 @@ export default class Button extends ComponentBase {
     targetsSelectors: ':is(p,div):has(> a:only-child)',
     selectorTest: (el) => el.childNodes.length === 1,
   };
-
-  nestedComponentsConfig = {};
+
+  nestedComponentsConfig = {
+    columns: {
+      componentName: 'columns',
+      active: false,
+      loaderConfig: {
+        targetsAsContainers: false,
+      },
+    },
+  };
 
   extendConfig() {
     return [

diff --git a/blocks/column/column.js b/blocks/column/column.js
@@ -1,7 +1,6 @@
 import ComponentBase from '../../scripts/component-base.js';
 
-// ! Solution 1 to remove mixins
-export default class ColumnN extends ComponentBase {
+export default class Column extends ComponentBase {
   static observedAttributes = ['position', 'size', 'justify'];
 
   connected() {

diff --git a/blocks/columns/columns.js b/blocks/columns/columns.js
@@ -1,6 +1,5 @@
 import { collectAttributes } from '../../scripts/libs.js';
 
-// ! Solution 2 to remove mixins
 export default class Columns {
   static observedAttributes = ['position', 'size', 'justify'];
 

diff --git a/scripts/component-loader.js b/scripts/component-loader.js
@@ -134,7 +134,7 @@ export default class ComponentLoader {
     );
 
     Object.keys(currentAttributes).forEach((key) => {
-      componentElem.setAttribute(key, currentAttributes[key]);
+      componentElem.setAttribute(key, currentAttributes[key].trim());
     });
 
     componentElem.nestedComponentsConfig = deepMerge(