Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch with the latest from boilerplate #114

Open
wants to merge 101 commits into
base: aem-dynamicmedia-demo
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
f410871
add css rules to hide header and footer until they are loaded
shsteimer Dec 7, 2023
8d4c9d4
chore(deps): update dependency stylelint to v16.1.0 (#314)
renovate[bot] Jan 10, 2024
c32b9b8
chore(deps): update dependency stylelint-config-standard to v36 (#315)
renovate[bot] Jan 10, 2024
bf77b13
chore(deps): update dependency chai to v5 (#316)
renovate[bot] Jan 10, 2024
92506a4
chore(deps): update dependency @babel/core to v7.23.7 (#317)
renovate[bot] Jan 10, 2024
0fcfb1c
chore(deps): update dependency semantic-release to v23 (#320)
renovate[bot] Jan 15, 2024
c15a94a
chore: update node version (#321)
tripodsan Jan 18, 2024
569c3e4
chore: get rid of semantic release (#322)
kptdobe Jan 18, 2024
154e0a0
fix(lib): update scripts/aem.js to [email protected]
semantic-release-bot Jan 22, 2024
8f80c98
chore(doc): link to cli in README (#330)
dylandepass Feb 5, 2024
a5fef7f
Merge pull request #325 from adobe/update-lib-aem-patch-1-5-1
fkakatie Mar 13, 2024
2413ba1
chore(deps): update dependency stylelint to v16.2.1 (#324)
renovate[bot] Mar 18, 2024
7eca224
chore(deps): update dependency chai to v5.1.0 (#328)
renovate[bot] Mar 18, 2024
5aad660
chore(deps): update babel monorepo (#329)
renovate[bot] Mar 18, 2024
7504c5d
chore(deps): update dependency eslint to v8.57.0 (#333)
renovate[bot] Mar 18, 2024
152fab7
chore(deps): update dependency stylelint to v16.3.1 (#341)
renovate[bot] Apr 3, 2024
e076487
chore(deps): update babel monorepo (#340)
renovate[bot] Apr 3, 2024
ad6f113
Update cleanup-on-create.yaml
gargadobe Apr 4, 2024
945c725
Update cleanup-on-create.yaml
gargadobe Apr 4, 2024
de3f824
Update cleanup-on-create.yaml
gargadobe Apr 4, 2024
34be78b
chore(deps): update dependency @babel/core to v7.24.4 (#342)
renovate[bot] Apr 4, 2024
f5198b5
fix: header/footer fragment loading (#13)
buuhuu Apr 9, 2024
4507539
chore: unify header/footer decoration
fkakatie Apr 12, 2024
72e2aa5
Merge pull request #346 from Buuhuu/fix-header-footer-loading
fkakatie Apr 12, 2024
1449ba1
chore: merge
fkakatie Apr 15, 2024
1043b03
Merge pull request #347 from adobe/unify-head-foot
fkakatie Apr 15, 2024
6de469b
Merge branch 'adobe:main' into main
gargadobe Apr 15, 2024
b5c3938
fix(lib): update scripts/aem.js to [email protected]
semantic-release-bot Apr 17, 2024
3a81533
Merge pull request #350 from adobe/update-lib-aem-patch-1-5-4
trieloff Apr 17, 2024
8fc9e9b
Merge pull request #344 from gargadobe/main
trieloff Apr 19, 2024
08a03db
fix: cards fail if text contains an icon
buuhuu Apr 19, 2024
c18ef3e
fix(404): do not include target, as it is redundant with URL
trieloff Apr 24, 2024
cb55461
Merge pull request #357 from adobe/404-target
trieloff May 7, 2024
c09ad01
fix: clarify eslint rules
fkakatie May 24, 2024
ac33e79
feat: add quote parity with eslint in stylelint
fkakatie May 24, 2024
9bd21a0
chore: lint
fkakatie May 24, 2024
892e3f0
fix: remove unused rule
fkakatie May 24, 2024
6b99daa
fix: remove deprecated root var
fkakatie May 24, 2024
4be1344
feat: added updated fonts
fkakatie May 24, 2024
7a260c0
fix: apply s2 font styles
fkakatie May 24, 2024
afee66e
fix: increase body font size
fkakatie May 24, 2024
7b3ab37
chore: unify color vars against s2 spec
fkakatie May 24, 2024
d105bef
fix: increase color contrast between bg and link
fkakatie May 24, 2024
5722538
fix: increase contrast between link and text
fkakatie May 24, 2024
4a3d34f
fix: unify container padding, margins, radius
fkakatie May 29, 2024
5f4dde6
chore(deps): update dependency stylelint to v16.6.1 (#356)
renovate[bot] Jun 5, 2024
d611f99
chore(deps): update babel monorepo to v7.24.6 (#358)
renovate[bot] Jun 5, 2024
94d6c3f
chore(deps): update dependency chai to v5.1.1 (#360)
renovate[bot] Jun 5, 2024
7ea508f
chore(deps): update babel monorepo to v7.24.7 (#367)
renovate[bot] Jun 5, 2024
51acbed
fix: link color meets background AND text contrast reqs
fkakatie Jun 6, 2024
72b31eb
chore: remove unused dep (#368)
kptdobe Jun 7, 2024
dfe221a
fix: close the nav when it loses focus, e.g keyboard user tabs out of it
shsteimer Jun 13, 2024
232d7d7
fix: manual patch of sampleRUM (#370)
kptdobe Jun 18, 2024
4cc1faa
feat: better error tracking (#375)
kptdobe Jun 27, 2024
c633b9e
feat(lib): update scripts/aem.js to [email protected] (#378)
adobe-bot Jul 1, 2024
caa123b
feat: section loader
davidnuescheler Jul 16, 2024
88af1ef
chore(deps): update dependency stylelint to v16.7.0 (#381)
renovate[bot] Jul 16, 2024
b20ffad
chore(deps): update dependency @babel/eslint-parser to v7.24.8 (#380)
renovate[bot] Jul 16, 2024
f9f0cda
chore(deps): update dependency stylelint-config-standard to v36.0.1 (…
renovate[bot] Jul 16, 2024
bd22328
feat(lib): update scripts/aem.js to [email protected] (#383)
adobe-bot Jul 16, 2024
8f226c2
feat: use rum js v2 (#371)
kptdobe Jul 16, 2024
516d856
Merge pull request #362 from adobe/unify-font
fkakatie Jul 30, 2024
fa63d2e
Merge branch 'main' into unify-color
fkakatie Jul 30, 2024
3fd179a
fix: a11y contrast fix
fkakatie Jul 30, 2024
91f0171
chore: lint
fkakatie Jul 30, 2024
1fb21ab
fix: a styles
fkakatie Jul 30, 2024
bb8e1bd
Merge pull request #363 from adobe/unify-color
fkakatie Jul 30, 2024
89875ad
Merge branch 'main' into unify-containers
fkakatie Jul 30, 2024
3e83daa
Merge pull request #364 from adobe/unify-containers
fkakatie Jul 30, 2024
82a84c5
Merge branch 'main' into issue-304-header-footer-cls
fkakatie Jul 30, 2024
8676c36
Merge pull request #305 from shsteimer/issue-304-header-footer-cls
fkakatie Jul 30, 2024
555e045
Merge pull request #354 from buuhuu/fix-cards-text-with-icon
fkakatie Jul 30, 2024
980829d
chore: lint
fkakatie Jul 30, 2024
66f47c4
Merge pull request #369 from shsteimer/header-nav-a11y-fix
fkakatie Jul 30, 2024
aaa920b
chore: a11y colors
fkakatie Aug 1, 2024
d83608a
fix: border color on cards
fkakatie Aug 1, 2024
d01adf4
fix: a11y header, ul > li role
fkakatie Aug 1, 2024
c0f0641
fix(lib): update scripts/aem.js to [email protected] (#388)
adobe-bot Aug 13, 2024
fd1eb97
chore(deps): update dependency @babel/eslint-parser to v7.25.1 (#385)
renovate[bot] Aug 13, 2024
1195d26
chore(deps): update dependency stylelint to v16.8.1 (#386)
renovate[bot] Aug 13, 2024
2b74bad
chore: add editor config (#353)
sippsolutions Aug 14, 2024
2c67bed
updating url to .aem.live from .hlx.live
kmurugulla Aug 19, 2024
0f5aeb0
docs: updating the preview and live urls in readme to .aem.page and .…
kmurugulla Aug 19, 2024
8f569fa
fix(lib): update scripts/aem.js to [email protected] (#391)
adobe-bot Aug 22, 2024
f6e144d
chore(deps): update dependency stylelint to v16.8.2 (#389)
renovate[bot] Aug 22, 2024
b981163
docs(readme): use correct AEM Live link
trieloff Sep 2, 2024
177810e
Merge pull request #396 from adobe/trieloff-patch-2
trieloff Sep 2, 2024
220bc9b
chore(github): update pull request template to use aem.live
trieloff Sep 2, 2024
7312419
Merge pull request #390 from kmurugulla/update-helix-urls
kmurugulla Sep 24, 2024
5bb132d
chore(deps): update dependency eslint to v8.57.1 (#401)
renovate[bot] Oct 17, 2024
f66d1b0
chore(deps): update dependency eslint-plugin-import to v2.31.0 (#397)
renovate[bot] Oct 17, 2024
1a18605
chore(deps): update dependency @babel/eslint-parser to v7.25.8 (#407)
renovate[bot] Oct 17, 2024
7e2b9a2
chore(deps): update dependency stylelint to v16.10.0 (#395)
renovate[bot] Oct 17, 2024
194070f
fix(lib): update scripts/aem.js to [email protected] (#420)
adobe-bot Oct 17, 2024
bc700f5
feat: remove unnecessary sampleRUM.enhance (#418)
kptdobe Oct 17, 2024
5e7bd30
chore(deps): update dependency @babel/eslint-parser to v7.25.9 (#421)
renovate[bot] Oct 28, 2024
da907b2
fix(lib): update scripts/aem.js to [email protected] (#431)
adobe-bot Nov 18, 2024
f95aa0a
chore(doc): link to key documentation pages
kptdobe Nov 21, 2024
934b5e7
chore: rename
kptdobe Nov 21, 2024
74950b3
Merge pull request #435 from adobe/doc
fkakatie Nov 21, 2024
84b6a39
chore(deps): update dependency stylelint to v16.11.0 (#436)
renovate[bot] Dec 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[*.js]
indent_size = 2

[*.css]
indent_size = 4
9 changes: 3 additions & 6 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,8 @@ module.exports = {
requireConfigFile: false,
},
rules: {
// allow reassigning param
'no-param-reassign': [2, { props: false }],
'linebreak-style': ['error', 'unix'],
'import/extensions': ['error', {
js: 'always',
}],
'import/extensions': ['error', { js: 'always' }], // require js file extensions in imports
'linebreak-style': ['error', 'unix'], // enforce unix linebreaks
'no-param-reassign': [2, { props: false }], // allow modifying properties of param
},
};
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ Please always provide the [GitHub issue(s)](../issues) your PR is for, as well a
Fix #<gh-issue-id>

Test URLs:
- Before: https://main--{repo}--{owner}.hlx.live/
- After: https://<branch>--{repo}--{owner}.hlx.live/
- Before: https://main--{repo}--{owner}.aem.live/
- After: https://<branch>--{repo}--{owner}.aem.live/
14 changes: 5 additions & 9 deletions .github/workflows/cleanup-on-create.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,26 @@ on:
create:
branches:
- main
workflow_dispatch:
jobs:
cleanup:
runs-on: ubuntu-latest
permissions:
contents: write
actions: write
# only run if commit message is "Initial commit" on main branch
if: ${{ github.ref == 'refs/heads/main' && github.event.head_commit.message == 'Initial commit' }}
if: ${{ github.event_name == 'workflow_dispatch' || ( github.ref == 'refs/heads/main' && !(contains(github.event, 'head_commit') || github.event.head_commit.message == 'Initial commit' )) }}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Use Node.js 18
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 18
- name: Uninstall dependencies
run: |
npm uninstall --save-dev semantic-release @semantic-release/git @semantic-release/changelog @semantic-release/exec
node-version: 20
- name: Remove Helper Files
run: |
rm -rf \
.github/workflows/cleanup-on-create.yaml \
.github/workflows/semantic-release.yaml \
.releaserc.cjs \
CHANGELOG.md

- name: Initialize README
Expand All @@ -47,7 +43,7 @@ jobs:
- name: Commit changes
run: |
git config --local user.email "[email protected]"
git config --local user.name "Helix Bot"
git config --local user.name "AEM Bot"
git add .
git commit -m "chore: cleanup repository template"
git push
14 changes: 14 additions & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Build
on: [push]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 20
- run: npm ci
- run: npm run lint
17 changes: 0 additions & 17 deletions .github/workflows/run-tests.yaml

This file was deleted.

23 changes: 0 additions & 23 deletions .github/workflows/semantic-release.yaml

This file was deleted.

18 changes: 0 additions & 18 deletions .releaserc.cjs

This file was deleted.

2 changes: 1 addition & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": ["stylelint-config-standard"]
}
}
9 changes: 5 additions & 4 deletions 404.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
<meta property="og:title" content="Page not found">
<script src="/scripts/scripts.js" type="module" crossorigin="use-credentials"></script>
<script type="module">
import { sampleRUM } from '/scripts/aem.js';

window.addEventListener('load', () => {
if (document.referrer) {
const { origin, pathname } = new URL(document.referrer);
Expand All @@ -26,9 +24,12 @@
btnContainer.append(backBtn);
}
}
sampleRUM('404', { source: document.referrer, target: window.location.href });
});
</script>
<script type="module">
import { sampleRUM } from '/scripts/aem.js';
sampleRUM('404', { source: document.referrer });
</script>
<link rel="stylesheet" href="/styles/styles.css">
<style>
main.error {
Expand All @@ -42,7 +43,7 @@
}

main.error .error-number text {
font-family: var(--fixed-font-family);
font-family: monospace;
}
</style>
<link rel="stylesheet" href="/styles/lazy-styles.css">
Expand Down
58 changes: 0 additions & 58 deletions CHANGELOG.md

This file was deleted.

1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,3 @@ One of the maintainers will look at the pull request within one week. Feedback o
The project's committers will release to the [Adobe organization on npmjs.org](https://www.npmjs.com/org/adobe).
Please contact the [Adobe Open Source Advisory Board](https://git.corp.adobe.com/OpenSourceAdvisoryBoard/discuss/issues) to get access to the npmjs organization.

The release process is fully automated using `semantic-release`, increasing the version numbers, etc. based on the contents of the commit messages found.
16 changes: 12 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@
Your project's description...

## Environments
- Preview: https://main--{repo}--{owner}.hlx.page/
- Live: https://main--{repo}--{owner}.hlx.live/
- Preview: https://main--{repo}--{owner}.aem.page/
- Live: https://main--{repo}--{owner}.aem.live/

## Documentation

Before using the aem-boilerplate, we recommand you to go through the documentation on https://www.aem.live/docs/ and more specifically:
1. [Developer Tutorial](https://www.aem.live/developer/tutorial)
2. [The Anatomy of a Project](https://www.aem.live/developer/anatomy-of-a-project)
3. [Web Performance](https://www.aem.live/developer/keeping-it-100)
4. [Markup, Sections, Blocks, and Auto Blocking](https://www.aem.live/developer/markup-sections-blocks)

## Installation

Expand All @@ -21,6 +29,6 @@ npm run lint

1. Create a new repository based on the `aem-boilerplate` template and add a mountpoint in the `fstab.yaml`
1. Add the [AEM Code Sync GitHub App](https://github.com/apps/aem-code-sync) to the repository
1. Install the [AEM CLI](https://github.com/adobe/aem-cli): `npm install -g @adobe/aem-cli`
1. Install the [AEM CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/aem-cli`
1. Start AEM Proxy: `aem up` (opens your browser at `http://localhost:3000`)
1. Open the `{repo}` directory in your favorite IDE and start coding :)
1. Open the `{repo}` directory in your favorite IDE and start coding :)
12 changes: 4 additions & 8 deletions blocks/cards/cards.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
margin: 0;
padding: 0;
display: grid;
grid-template-columns: repeat(auto-fill, minmax(278px, 1fr));
grid-gap: 16px;
grid-template-columns: repeat(auto-fill, minmax(257px, 1fr));
grid-gap: 24px;
}

.cards > ul > li {
border: 1px solid var(--dark-color);
background-color: var(--background-color)
border: 1px solid #dadada;
background-color: var(--background-color);
}

.cards .cards-card-body {
Expand All @@ -20,10 +20,6 @@
line-height: 0;
}

.cards .cards-card-body > *:first-child {
margin-top: 0;
}

.cards > ul > li img {
width: 100%;
aspect-ratio: 4 / 3;
Expand Down
2 changes: 1 addition & 1 deletion blocks/cards/cards.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function decorate(block) {
});
ul.append(li);
});
ul.querySelectorAll('img').forEach((img) => img.closest('picture').replaceWith(createOptimizedPicture(img.src, img.alt, false, [{ width: '750' }])));
ul.querySelectorAll('picture > img').forEach((img) => img.closest('picture').replaceWith(createOptimizedPicture(img.src, img.alt, false, [{ width: '750' }])));
block.textContent = '';
block.append(ul);
}
2 changes: 1 addition & 1 deletion blocks/columns/columns.css
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
.columns > div {
align-items: center;
flex-direction: unset;
gap: 32px;
gap: 24px;
}

.columns > div > div {
Expand Down
14 changes: 10 additions & 4 deletions blocks/footer/footer.css
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
footer {
padding: 2rem;
background-color: var(--light-color);
font-size: var(--body-font-size-s);
font-size: var(--body-font-size-xs);
}

footer .footer {
max-width: 1200px;
footer .footer > div {
margin: auto;
max-width: 1200px;
padding: 40px 24px 24px;
}

footer .footer p {
margin: 0;
}

@media (width >= 900px) {
footer .footer > div {
padding: 40px 32px 24px;
}
}
7 changes: 3 additions & 4 deletions blocks/footer/footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@ import { loadFragment } from '../fragment/fragment.js';
* @param {Element} block The footer block element
*/
export default async function decorate(block) {
// load footer as fragment
const footerMeta = getMetadata('footer');
block.textContent = '';

// load footer fragment
const footerPath = footerMeta.footer || '/footer';
const footerPath = footerMeta ? new URL(footerMeta, window.location).pathname : '/footer';
const fragment = await loadFragment(footerPath);

// decorate footer DOM
block.textContent = '';
const footer = document.createElement('div');
while (fragment.firstElementChild) footer.append(fragment.firstElementChild);

Expand Down
14 changes: 1 addition & 13 deletions blocks/fragment/fragment.css
Original file line number Diff line number Diff line change
@@ -1,13 +1 @@
/* suppress nested section padding */
.fragment-wrapper > .section {
padding-left: 0;
padding-right: 0;
}

.fragment-wrapper > .section:first-of-type {
padding-top: 0;
}

.fragment-wrapper > .section:last-of-type {
padding-bottom: 0;
}
/* stylelint-disable no-empty-source */
Loading