Skip to content

Commit

Permalink
Merge pull request #1 from buuhuu/image-carousel
Browse files Browse the repository at this point in the history
fix: adding Image Carousel
  • Loading branch information
anagarwa authored Jul 19, 2024
2 parents 2732545 + 15703d7 commit a53e791
Show file tree
Hide file tree
Showing 8 changed files with 42 additions and 6 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ helix-importer-ui
.DS_Store
*.bak
.idea
*.iml
3 changes: 3 additions & 0 deletions blocks/image-carousel/image-carousel.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.block {
text-align: center;
}
3 changes: 3 additions & 0 deletions blocks/image-carousel/image-carousel.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default async function decorate(block) {
console.log(`I am here ${block}`);
}
22 changes: 21 additions & 1 deletion component-definition.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@
"xwalk": {
"page": {
"resourceType": "core/franklin/components/image/v1/image",
"template": {}
"template": {
"name": "Image",
"model": "image",
"image": "/content/dam/aem-xwalk-test-harsh/content-at-scale.png",
"imageAlt": "Sample Image"
}
}
}
}
Expand Down Expand Up @@ -169,6 +174,21 @@
}
}
}
},
{
"title": "Image Carousel",
"id": "image-carousel",
"plugins": {
"xwalk": {
"page": {
"resourceType": "core/franklin/components/block/v1/block",
"template": {
"name": "Image Carousel",
"filter": "image-carousel"
}
}
}
}
}
]
}
Expand Down
10 changes: 9 additions & 1 deletion component-filters.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"title",
"hero",
"cards",
"columns"
"columns",
"image-carousel"
]
},
{
Expand All @@ -45,5 +46,12 @@
"button",
"title"
]
},
{
"id": "image-carousel",
"components": [
"image"
]
}

]
4 changes: 2 additions & 2 deletions component-models.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@
{
"component": "reference",
"valueType": "string",
"name": "fileReference",
"name": "image",
"label": "Image",
"multi": false
},
{
"component": "text",
"valueType": "string",
"name": "alt",
"name": "imageAlt",
"value": "Default alt",
"label": "Alt Text"
}
Expand Down
3 changes: 2 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"homepage": "https://github.com/adobe/aem-boilerplate#readme",
"devDependencies": {
"@babel/eslint-parser": "7.24.1",
"eslint": "8.57.0",
"eslint": "^8.57.0",
"eslint-config-airbnb-base": "15.0.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-json": "3.1.0",
Expand Down

0 comments on commit a53e791

Please sign in to comment.