Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/article list #92

Merged
merged 15 commits into from
Jan 22, 2024
Merged

Feature/article list #92

merged 15 commits into from
Jan 22, 2024

Conversation

kailasnadh790
Copy link
Collaborator

@kailasnadh790 kailasnadh790 commented Jan 19, 2024 •
edited
Loading

@kailasnadh790
initial commit
a30bb98
@kailasnadh790
Merge branch 'main' of https://github.com/hlxsites/famous-smoke-cigar…
9131cfd 
…advisor into feature/article-list

# Conflicts:
#	cigaradvisor/blocks/article-list/article-list.css
#	cigaradvisor/blocks/article-list/article-list.js
#	cigaradvisor/blocks/article-teaser/article-teaser.css
@kailasnadh790
article-list
5c2a3e8
@kailasnadh790 kailasnadh790 requested a review from bstopp January 19, 2024 20:51
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@kailasnadh790 kailasnadh790 marked this pull request as draft January 19, 2024 20:51
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 19, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/author/john-pullo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cigaradvisor/drafts/Kailas/buying-guides-pageination PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kailasnadh790 kailasnadh790 requested a review from bstopp January 19, 2024 21:29
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 21, 2024 04:59 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 21, 2024 20:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 21, 2024 20:42 Inactive
@kailasnadh790 kailasnadh790 linked an issue Jan 21, 2024 that may be closed by this pull request
Pagintated Article List #9
Closed
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 03:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 03:20 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 17:43 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 17:53 Inactive
@kailasnadh790 kailasnadh790 self-assigned this Jan 22, 2024
@kailasnadh790 kailasnadh790 marked this pull request as ready for review January 22, 2024 17:53
@kailasnadh790 kailasnadh790 requested a review from bstopp January 22, 2024 17:53
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 18:01 Inactive
bstopp
bstopp requested changes Jan 22, 2024
View reviewed changes
cigaradvisor/blocks/article-list/article-list.css Outdated Show resolved Hide resolved
cigaradvisor/scripts/scripts.js Outdated Show resolved Hide resolved
cigaradvisor/scripts/scripts.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 20:14 Inactive
@kailasnadh790 kailasnadh790 requested a review from bstopp January 22, 2024 20:14
@aem-code-sync aem-code-sync bot temporarily deployed to feature/article-list January 22, 2024 20:18 Inactive
@kailasnadh790 kailasnadh790 merged commit 3552c3e into main Jan 22, 2024
2 checks passed
@kailasnadh790 kailasnadh790 deleted the feature/article-list branch January 22, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstopp bstopp bstopp approved these changes

Assignees

@kailasnadh790 kailasnadh790

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagintated Article List
2 participants
@kailasnadh790 @bstopp