Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/author template #86

Merged
merged 21 commits into from
Jan 19, 2024
Merged

Feat/author template #86

merged 21 commits into from
Jan 19, 2024

Conversation

kailasnadh790
Copy link
Collaborator

@kailasnadh790 kailasnadh790 commented Jan 18, 2024 •
edited by bstopp
Loading

@kailasnadh790 kailasnadh790 requested a review from bstopp January 18, 2024 19:00
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 18, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 18, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/author/cigar-advisor-staff PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cigaradvisor/author/john-pullo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kailasnadh790 kailasnadh790 marked this pull request as draft January 18, 2024 19:07
@kailasnadh790 kailasnadh790 marked this pull request as ready for review January 18, 2024 19:37
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 18, 2024 19:37 Inactive
kailasnadh790 and others added 4 commits January 18, 2024 13:55
@kailasnadh790 @bstopp
Feature/404 (#79)
eb53b3f 
* hero

* initial commit

* errorpage

* Update hero.js

* Revert "Update hero.js"

This reverts commit 5cd8a85.

* Revert "hero"

This reverts commit 5e3525e.

---------

Co-authored-by: Bryan Stopp <[email protected]>
@bstopp
Dont need author template logic any more.
1f899a6
@bstopp
Fix a bit of the social stuff.
32ba073
@bstopp
Fix some minor details on author detail block.
b012917
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 18, 2024 21:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 18, 2024 22:08 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 18, 2024 22:09 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 18, 2024 22:11 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 18, 2024 22:20 Inactive
kronnox
kronnox requested changes Jan 19, 2024
View reviewed changes
helix-query.yaml Outdated Show resolved Hide resolved
@kailasnadh790 kailasnadh790 linked an issue Jan 19, 2024 that may be closed by this pull request
Author page: author details block #85
Closed
@bstopp bstopp marked this pull request as draft January 19, 2024 15:49
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 19, 2024 18:05 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 19, 2024 18:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 19, 2024 18:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat/author-template January 19, 2024 18:16 Inactive
@bstopp bstopp marked this pull request as ready for review January 19, 2024 18:17
@bstopp bstopp merged commit 99a4615 into main Jan 19, 2024
2 checks passed
@bstopp bstopp deleted the feat/author-template branch January 19, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kronnox kronnox kronnox requested changes

@bstopp bstopp Awaiting requested review from bstopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author page: author details block
3 participants
@kailasnadh790 @bstopp @kronnox