Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer layout and outline #82

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Fix footer layout and outline #82

merged 2 commits into from
Jan 18, 2024

Conversation

Copy link

aem-code-sync bot commented Jan 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 18, 2024

Page Scores Audits Google
/cigaradvisor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kronnox kronnox requested a review from bstopp January 18, 2024 10:52
@kronnox
Copy link
Collaborator Author

kronnox commented Jan 18, 2024

@bstopp After some research I came to the conclusion it would be best to keep the headings in the footer. I improved the HTML5 document outline to reduce risk of the headings being misinterpreted [1]. This is all according to specification [2], but a lot of screenreaders have never fully adopted the HTML5 document outline [3]. That's why we should still follow the general heading hierarchy of the site (added a hidden footer h2 heading to clean this up [4]).

[1] https://iloveseo.com/seo/john-mueller-explained-how-one-could-use-h2-tags-in-the-footer/
[2] https://html.spec.whatwg.org/multipage/sections.html#the-footer-element
[3] http://html5doctor.com/computer-says-no-to-html5-document-outline/
[4] http://html5doctor.com/outlines/

@kronnox kronnox merged commit d52672a into main Jan 18, 2024
2 checks passed
@kronnox kronnox deleted the bug/footer-layout branch January 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants