Feature/404 #79
Merged
Feature/404 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Closed
bstopp
requested changes
Jan 18, 2024
cigaradvisor/blocks/hero/hero.css
Outdated
| @@ -15,7 +14,7 @@ main .hero.block { | |||
| } | |||
|
|
|||
| main .hero.block.under-nav { | |||
| margin-top: -43px; | |||
| padding-top: 60px; | |||
There was a problem hiding this comment.
You can't change the padding of the hero like this. It impacts other places.
There was a problem hiding this comment.
Currently this hero is used in home page and pages like 404, I have verified this change works both these places.
bstopp
reviewed
Jan 18, 2024
bstopp
approved these changes
Jan 18, 2024
bstopp
added a commit
that referenced
this pull request
Jan 18, 2024
* hero * initial commit * errorpage * Update hero.js * Revert "Update hero.js" This reverts commit 5cd8a85. * Revert "hero" This reverts commit 5e3525e. --------- Co-authored-by: Bryan Stopp <[email protected]>
bstopp
added a commit
that referenced
this pull request
Jan 19, 2024
* Auto-block Author Template & add author detail block. * update author index. * Fix missing header h1. * Update author-detail.css * author details * Update author-detail.css * variables * Feature/404 (#79) * hero * initial commit * errorpage * Update hero.js * Revert "Update hero.js" This reverts commit 5cd8a85. * Revert "hero" This reverts commit 5e3525e. --------- Co-authored-by: Bryan Stopp <[email protected]> * Dont need author template logic any more. * Fix a bit of the social stuff. * Fix some minor details on author detail block. * Styling fixes for image. * Double method declaration? * Empty list css file for now. * Fix bg image for performance. * Linting. * Eager load profile image. * Eager load lcp image. --------- Co-authored-by: Bryan Stopp <[email protected]> Co-authored-by: Bryan Stopp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17
Test URLs: