Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hero slightly. #75

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Refactor Hero slightly. #75

merged 4 commits into from
Jan 17, 2024

Conversation

bstopp
Copy link
Collaborator

@bstopp bstopp commented Jan 16, 2024

Push all hero markup generation logic into the hero block.

Test URLs:

Copy link

aem-code-sync bot commented Jan 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 16, 2024

Page Scores Audits Google
/cigaradvisor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

kronnox
kronnox previously approved these changes Jan 17, 2024
@bstopp bstopp merged commit f03cdde into main Jan 17, 2024
2 checks passed
@bstopp bstopp deleted the bug/hero branch January 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants