Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/header #52

Merged
merged 26 commits into from
Jan 9, 2024
Merged

Feature/header #52

merged 26 commits into from
Jan 9, 2024

Conversation

kailasnadh790
Copy link
Collaborator

@kailasnadh790 kailasnadh790 commented Jan 5, 2024 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 5, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@kailasnadh790 kailasnadh790 linked an issue Jan 5, 2024 that may be closed by this pull request
Header Block #2
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 5, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/drafts/Kailas/new-grid PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kailasnadh790 kailasnadh790 requested a review from bstopp January 5, 2024 16:56
@kailasnadh790 kailasnadh790 requested a review from tmaret January 8, 2024 19:58
tmaret
tmaret previously approved these changes Jan 9, 2024
View reviewed changes
@kailasnadh790
Merge branch 'main' of https://github.com/hlxsites/famous-smoke-cigar…
3ad001f 
…advisor into feature/header

# Conflicts:
#	cigaradvisor/styles/styles.css
@kailasnadh790 kailasnadh790 requested a review from tmaret January 9, 2024 13:54
@kailasnadh790 kailasnadh790 merged commit 18cd95a into main Jan 9, 2024
2 checks passed
@kailasnadh790 kailasnadh790 deleted the feature/header branch January 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmaret tmaret tmaret approved these changes

@bstopp bstopp Awaiting requested review from bstopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Block
2 participants
@kailasnadh790 @tmaret