Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/authorcard #45

Closed
wants to merge 10 commits into from
Closed

Feature/authorcard #45

wants to merge 10 commits into from

Conversation

kailasnadh790
Copy link
Collaborator

@kailasnadh790 kailasnadh790 requested a review from bstopp December 18, 2023 16:55
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 18, 2023 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 18, 2023 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/drafts/Kailas/authorcard PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to feature/authorcard December 18, 2023 16:57 Inactive
bstopp
bstopp requested changes Dec 18, 2023
View reviewed changes
head.html Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to feature/authorcard December 19, 2023 03:55 Inactive
@kailasnadh790 kailasnadh790 requested a review from bstopp December 19, 2023 04:00
@aem-code-sync aem-code-sync bot temporarily deployed to feature/authorcard December 19, 2023 15:18 Inactive
@kailasnadh790
Merge branch 'main' of https://github.com/hlxsites/famous-smoke-cigar…
35578c9 
…advisor into feature/authorcard

# Conflicts:
#	cigaradvisor/styles/fonts.css
@aem-code-sync aem-code-sync bot temporarily deployed to feature/authorcard December 19, 2023 17:09 Inactive
@kailasnadh790 kailasnadh790 linked an issue Dec 20, 2023 that may be closed by this pull request
Author Card #8
Closed
bstopp
bstopp requested changes Dec 20, 2023
View reviewed changes
cigaradvisor/blocks/authorcard/authorcard.css Outdated Show resolved Hide resolved
cigaradvisor/blocks/authorcard/authorcard.css Outdated Show resolved Hide resolved
cigaradvisor/blocks/authorcard/authorcard.css Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to feature/authorcard December 30, 2023 02:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/authorcard December 30, 2023 02:53 Inactive
@kailasnadh790 kailasnadh790 requested a review from bstopp January 5, 2024 18:30
@kailasnadh790 kailasnadh790 requested a review from tmaret January 8, 2024 19:58
tmaret
tmaret previously approved these changes Jan 9, 2024
View reviewed changes
@kailasnadh790
Merge branch 'main' of https://github.com/hlxsites/famous-smoke-cigar…
c07afa3 
…advisor into feature/authorcard

# Conflicts:
#	cigaradvisor/scripts/scripts.js
#	cigaradvisor/styles/lazy-styles.css
#	cigaradvisor/styles/styles.css
@kailasnadh790 kailasnadh790 requested a review from tmaret January 10, 2024 12:49
@kailasnadh790 kailasnadh790 requested a review from tmaret January 10, 2024 14:03
@kailasnadh790 kailasnadh790 deleted the feature/authorcard branch January 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmaret tmaret tmaret approved these changes

@kronnox kronnox Awaiting requested review from kronnox

@bstopp bstopp Awaiting requested review from bstopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author Card
4 participants
@kailasnadh790 @tmaret @bstopp @kronnox