Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FAQ ld json to article pages #313

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Add FAQ ld json to article pages #313

merged 6 commits into from
Jun 14, 2024

Conversation

bdeffleyfamous
Copy link
Collaborator

@bdeffleyfamous bdeffleyfamous commented Jun 13, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #312

Article pages that contain a FAQ should contain a ld json script tag with using the FAQPage format.

Test URLs:

@bdeffleyfamous bdeffleyfamous linked an issue Jun 13, 2024 that may be closed by this pull request
Create FAQ jsonld #312
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 13, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 13, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/buying-guides/cohiba-cigars PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 312-create-faq-jsonld June 13, 2024 15:05 Inactive
@bdeffleyfamous bdeffleyfamous requested a review from bstopp June 13, 2024 15:08
@bdeffleyfamous bdeffleyfamous self-assigned this Jun 13, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 312-create-faq-jsonld June 13, 2024 17:48 Inactive
bstopp
bstopp previously approved these changes Jun 13, 2024
View reviewed changes
codecodeio
codecodeio requested changes Jun 14, 2024
View reviewed changes
cigaradvisor/scripts/linking-data.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to 312-create-faq-jsonld June 14, 2024 13:16 Inactive
codecodeio
codecodeio approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I even added some additional content and it only picks up on the one FAQ section. The faq schema validates.

tonyklapatch
tonyklapatch approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, schema is validating correctly.

@tonyklapatch tonyklapatch merged commit f22f292 into main Jun 14, 2024
2 checks passed
@tonyklapatch tonyklapatch deleted the 312-create-faq-jsonld branch June 14, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyklapatch tonyklapatch tonyklapatch approved these changes

@bstopp bstopp bstopp approved these changes

@codecodeio codecodeio codecodeio approved these changes

Assignees

@bdeffleyfamous bdeffleyfamous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create FAQ jsonld
4 participants
@bdeffleyfamous @codecodeio @bstopp @tonyklapatch