Feature/image cta #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
|
|
tmaret
previously approved these changes
Dec 1, 2023
bstopp
requested changes
Dec 1, 2023
There was a problem hiding this comment.
I'd like to get picture element to pre-save the space for the image, which will be lazy loaded. Without this we'll end up with CLS issues if the block is marked as finished, but then the image loads after other, subsequent, blocks.
This can be done with two steps:
- Set the
pictureto be relative position, then absolute position the image within it. Example CSS - Calculate the width-to-height ratio. Then add this as padding (bottom or top). This creates the space in which the Image will fit when rendered. Example JS.
- This step should also set the max-width based on the original image's width. This way the image doesn't grow larger than desired, which can result in pixelation.
This is an example I've used to do this same approach for the free-form images in long form pages:
bstopp
approved these changes
Dec 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Issue: #7
Test URLs: