Load article list asynchronously #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kailasnadh790
approved these changes
Mar 6, 2024
|
Seems like PSI score is poor due to high TBT. |
tmaret
approved these changes
Mar 6, 2024
|
Need to rebase/resolve conflicts - but i'm wondering if the updates for perf improvements are still needed. I agree we need to refactor the HTML generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to investigate #260 and refactored the article loading in the article-list as part of it. Didn't resolve the issue, but is still a nice improvement. Also contains refactorings that are part of #266.
Test URLs: