Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return-to-top block #103

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Add return-to-top block #103

merged 3 commits into from
Jan 23, 2024

Conversation

@kronnox kronnox added the enhancement New feature or request label Jan 23, 2024
@kronnox kronnox requested a review from bstopp January 23, 2024 09:40
Copy link

aem-code-sync bot commented Jan 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 23, 2024

Page Scores Audits Google
/cigaradvisor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kronnox kronnox changed the title Add return-to-top button Add return-to-top block Jan 23, 2024
@bstopp
Copy link
Collaborator

bstopp commented Jan 23, 2024

I'd prefer this to be in the auto-blocks section, but this works.

@kronnox
Copy link
Collaborator Author

kronnox commented Jan 23, 2024

I'd prefer this to be in the auto-blocks section, but this works.

I personally kind of disagree with that. I would argue that auto-blocking is more about automatically adding blocks based off default-content. Here we are automatically adding a whole separate aside that is not part of any content-group. And since this mechanism is very similar to how the header and footer get loaded, I think it fits perfectly there.

Let's revisit this while cleaning up. Happy to discuss this, but I'll go ahead and merge so it's present for the review for now.

@kronnox kronnox merged commit 937fdb8 into main Jan 23, 2024
2 checks passed
@bstopp bstopp deleted the issue/83 branch January 24, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return to top button
2 participants