Remove external fonts and replace font-awesome characters with icons (#…

…80) * remove external fonts * fix remaining font-awesome icons * minor cleanup
hlxsites · Jan 18, 2024 · cd34124 · cd34124
1 parent d1f1d73
commit cd34124
Show file tree

Hide file tree

Showing 15 changed files with 137 additions and 237 deletions.
diff --git a/cigaradvisor/blocks/article-teaser/article-teaser.css b/cigaradvisor/blocks/article-teaser/article-teaser.css
@@ -89,7 +89,7 @@
   display: flex;
   align-items: flex-start;
   flex: 1 0 13rem;
-  width: 100%;  
+  width: 100%;
 }
 
 .article-teaser.block .article.article-thumbnail .article-image>img {
@@ -238,12 +238,14 @@
 }
 
 .article-teaser.block .read-more::after {
-  content: '\f054';
-  font-family: FontAwesome, sans-serif;
+  display: inline-block;
+  width: 12px;
+  height: 12px;
+  content: url('/cigaradvisor/icons/angle-right.svg');
   margin-left: 8px;
-  line-height: 1.5;
-  color: #b19b5e;
-  font-size: 18px;
+  vertical-align: top;
+  margin-top: 2px;
+  filter: var(--clr-filter-subdued-gold);
 }
 
 .article-teaser.block .article-thumbnail .article-read-more {
@@ -296,4 +298,4 @@
   .article-teaser.block .article.article-thumbnail {
     min-height: 26.25rem;
   }
-}
+}
diff --git a/cigaradvisor/blocks/author/author.css b/cigaradvisor/blocks/author/author.css
@@ -83,37 +83,14 @@
 .author.block .author-details ul {
     display: flex;
     margin: 10px 0;
+
+    --icon-size: 20px;
 }
 
 .author.block .author-details ul li {
     margin-right: 20px;
 }
 
-.author.block .author-details ul li a::before {
-    font-family: var(--ff-fontawesome);
-    font-style: normal;
-    font-weight: bolder;
-    text-decoration: inherit;
-    font-size: 20px;
-    color: #141414
-}
-
-.author.block .author-details ul li.social-twitter a::before {
-    content: "\f099";
-}
-
-.author.block .author-details ul li.social-facebook a::before {
-    content: "\f39e";
-}
-
-.author.block .author-details ul li.social-instagram a::before {
-    content: "\f16d";
-}
-
-.author.block .author-details ul li.social-youtube a::before {
-    content: "\f167";
-}
-
 /* media queries */
 @media screen and (min-width: 900px) {
     .author.block>div {
@@ -153,6 +130,6 @@
     .author.block .author-details .author-heading {
         display: flex;
         flex-direction: row;
-        align-items: left;
+        align-items: start;
     }
-}
+}
diff --git a/cigaradvisor/blocks/author/author.js b/cigaradvisor/blocks/author/author.js
@@ -1,4 +1,5 @@
 import { decorateExternalLink } from '../../scripts/scripts.js';
+import { decorateIcons } from '../../scripts/aem.js';
 
 /**
  * Loads an author.
@@ -51,20 +52,38 @@ export default async function decorate(block) {
     if (authorPContent) {
       authorDetails.append(authorPContent);
     }
-    const socilaLinks = author.querySelector('ul');
-    if (socilaLinks) {
-      const socialItems = socilaLinks.querySelectorAll('li');
+    const socialLinks = author.querySelector('ul');
+    if (socialLinks) {
+      const socialItems = socialLinks.querySelectorAll('li > a');
       socialItems.forEach((item) => {
-        const textNode = item.childNodes[0];
-        if (textNode && textNode.textContent !== '') {
-          const text = `social-${textNode.textContent.trim()}`;
-          textNode.innerText = '';
-          const textToClass = text.toLowerCase().replace(/\s/g, '-');
-          item.className = textToClass;
+        const innerText = item.innerText.trim();
+        if (innerText && innerText !== '') {
+          let icon;
+          switch (innerText) {
+            case 'twitter':
+              icon = 'twitter';
+              break;
+            case 'facebook':
+              icon = 'facebook-f';
+              break;
+            case 'instagram':
+              icon = 'instagram';
+              break;
+            case 'youtube':
+              icon = 'youtube';
+              break;
+            case 'pintrest':
+              icon = 'pintrest-p';
+              break;
+            default:
+              icon = 'unknown';
+          }
+          item.innerHTML = `<span class="icon icon-${icon}"></span>`;
         }
       });
 
-      authorDetails.append(socilaLinks);
+      decorateIcons(socialLinks);
+      authorDetails.append(socialLinks);
     } else {
       const emptySocialLinks = document.createElement('ul');
       authorDetails.append(emptySocialLinks);