refactored

hlxsites · Dec 7, 2023 · 93c8367 · 93c8367
1 parent 07b8b33
commit 93c8367
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/cigaradvisor/blocks/imagecta/imagecta.js b/cigaradvisor/blocks/imagecta/imagecta.js
@@ -11,7 +11,8 @@ export default async function decorate(block) {
   anchor.append(picture);
   const link = block.querySelector('a').getAttribute('href');
   anchor.setAttribute('href', link);
-  anchor.setAttribute('target', isExternal(link));
+  anchor.setAttribute('target', isExternal(link) ? '_blank' : '_self');
+  anchor.setAttribute('title', img.alt);
   children.push(anchor);
   block.replaceChildren(...children);
 }
diff --git a/cigaradvisor/scripts/scripts.js b/cigaradvisor/scripts/scripts.js
@@ -93,10 +93,13 @@ export function decorateMain(main) {
   buildTwoColumnGrid(main);
 }
 
-export function isExternal(url) {
-  const anchor = document.createElement('a');
-  anchor.href = url;
-  return (anchor.hostname !== window.location.hostname) ? '_blank' : '_self';
+export function isExternal(path) {
+  try {
+    const url = new URL(path);
+    return window.location.hostname !== url.hostname;
+  } catch (error) {
+    return false;
+  }
 }
 
 /**