Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

fix: [UAT] listed issue 8 #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [UAT] listed issue 8 #163

wants to merge 1 commit into from

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented May 2, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented May 2, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@ramboz ramboz self-requested a review May 2, 2023 13:36
@ramboz
Copy link
Collaborator

ramboz commented May 3, 2023

Looking at a page like https://issue-159--delta--hlxsites.hlx.page/us/en/skymiles/how-to-earn-miles/earn-with-delta, I think the solution doesn't really work well.

And looking at https://issue-159--delta--hlxsites.hlx.page/us/en/skymiles/medallion-program/how-to-qualify which was the page with the issue, I think we should rather fix the CSS for:

.skymiles .default-content-wrapper p:first-child:has(strong) {
  margin-top: 3rem;
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UAT] Skymiles defects - chrome file - 2
2 participants