Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

issue-149 Add hidden descriptive text to links for a11y and SEO #151

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

issue-149 Add hidden descriptive text to links for a11y and SEO #151

wants to merge 4 commits into from

Conversation

Dereje24
Copy link
Collaborator

@Dereje24 Dereje24 commented Apr 26, 2023 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 26, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@Dereje24 Dereje24 requested a review from ramboz April 26, 2023 20:58
@aem-code-sync
Copy link

aem-code-sync bot commented Apr 26, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 26, 2023

Page Score PSI Audit Google
/us/en/skymiles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 26, 2023

Page Score PSI Audit Google
/us/en/skymiles/overview SI FCP LCP TBT CLS PSI

ramboz
ramboz reviewed Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@ramboz ramboz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing the [ and ´]´ in the final markup so they aren't read out by screen readers.

Screenshot 2023-04-26 at 2 13 54 PM

You can probably try a .slice(1, -1) in the replace method

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 26, 2023

Page Score PSI Audit Google
/us/en/skymiles/overview SI FCP LCP TBT CLS PSI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramboz ramboz ramboz left review comments

@askayastha22 askayastha22 Awaiting requested review from askayastha22

@cgoudie cgoudie Awaiting requested review from cgoudie

@asthabh23 asthabh23 Awaiting requested review from asthabh23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dereje24 @ramboz