Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ON HOLD] 850 search search popup #935

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[ON HOLD] 850 search search popup #935

wants to merge 14 commits into from

Conversation

amlan18041996
Copy link
Contributor

@amlan18041996 amlan18041996 linked an issue Mar 19, 2024 that may be closed by this pull request
[Search] Search Popup #850
Open
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Mar 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Mar 19, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup March 19, 2024 17:52 Inactive
davidzochowski
davidzochowski requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@davidzochowski davidzochowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments for first review

rgravitvl
rgravitvl requested changes Mar 20, 2024
View reviewed changes
blocks/header/header.js Outdated Show resolved Hide resolved
blocks/header/header.js Outdated Show resolved Hide resolved
blocks/header/header.js Outdated Show resolved Hide resolved
blocks/header/header.js Outdated Show resolved Hide resolved
@amlan18041996 amlan18041996 self-assigned this Mar 21, 2024
@amlan18041996 amlan18041996 marked this pull request as draft March 21, 2024 06:44
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup April 3, 2024 10:33 Inactive
@amlan18041996
Search Popup all API integration along with facet-selection-and-de_se…
4a022bc 
…lection, facet-with-number-of-results, search-result-page
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup April 5, 2024 20:45 Inactive
@amlan18041996 amlan18041996 marked this pull request as ready for review April 5, 2024 20:46
@amlan18041996 amlan18041996 marked this pull request as draft April 10, 2024 09:01
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup April 16, 2024 11:17 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup April 16, 2024 11:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup April 16, 2024 13:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup April 30, 2024 06:01 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup May 9, 2024 18:52 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 850-search-search-popup May 9, 2024 19:51 Inactive
@amlan18041996 amlan18041996 requested a review from rgravitvl May 9, 2024 19:54
@amlan18041996 amlan18041996 marked this pull request as ready for review May 9, 2024 19:55
@davenichols-DHLS davenichols-DHLS changed the title 850 search search popup [ON HOLD] 850 search search popup May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaack mhaack Awaiting requested review from mhaack

@davenichols-DHLS davenichols-DHLS Awaiting requested review from davenichols-DHLS

@sharanagoudapatil sharanagoudapatil Awaiting requested review from sharanagoudapatil

@davidzochowski davidzochowski Awaiting requested review from davidzochowski

@rgravitvl rgravitvl Awaiting requested review from rgravitvl

Requested changes must be addressed to merge this pull request.

Assignees

@amlan18041996 amlan18041996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search] Search Popup
4 participants
@amlan18041996 @rgravitvl @davidzochowski @davenichols-DHLS