Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero update - adding loader if we have values to display #516

Open
wants to merge 2,214 commits into
base: main
Choose a base branch
from
Open

Hero update - adding loader if we have values to display #516

wants to merge 2,214 commits into from

Conversation

ltiseanu
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 23, 2024 •
edited
Loading

Page Scores Audits Google
📱 /drafts/lucia-test/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/lucia-test/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

abutuza and others added 29 commits November 8, 2024 14:43
@abutuza
Merge pull request #373 from bitdefender/DEX-21121
6b99d5e 
DEX-21121 fixed tags wrapping
@iconstantin-bd
fixed errors when dotest=1 is used
275f0af
@iconstantin-bd
Merge pull request #374 from bitdefender/fix-target-experiments
65b4039 
fixed errors when dotest=1 is used
@Andserbanbitdefender
feat: add blackfriday style to columns
1b1278e
@Andserbanbitdefender
lint
ac88ab5
@iconstantin-bd
another approach to fixing the target experiments
edc54e6
@enake
Merge pull request #376 from bitdefender/fix-target-experiments
00689ee 
another approach to fixing the target experiments
@abutuza
removed language bar for ferrari page
8647402
@abutuza
lint fix
f602ea1
@abutuza
changed carousel active dots colour
1a9d69b
@abutuza
scuderia ferrari style adjustments
04d53dd
@abutuza
temporarily hidden language for scuderiaferrari page
2300acb
@abutuza
lint fix
2c93ccc
@abutuza
lint fix
e8194c0
@abutuza
Merge pull request #377 from bitdefender/DEX-20428
1d2d9dd 
DEX-20428 style adjustments
@iconstantin-bd
added extra check for the Visitor class instantiation
335f136
@iconstantin-bd
Merge pull request #378 from bitdefender/fix-non-loading-prices-issue…
0c36178 
…-TS-AV

added extra check for the Visitor class instantiation
@ltiseanu
option to change text and background color
b01a030
@Andserbanbitdefender
make new-prod-box subtitle accept more words
2c6a6f6
@Andserbanbitdefender
lint
2dc2a08
@ltiseanu
css for hidding the beradscrumb on hero banner
ff21190
@ltiseanu
hide signature
4e6531a
@ltiseanu
hide signature
0b2570e
@ltiseanu
move css to hero block
9c78eab
@ltiseanu
update css
4db12b8
@ltiseanu
update hero banner
602fd29
@Andserbanbitdefender
Merge pull request #375 from bitdefender/dex-20868
0469f59 
feat: add blackfriday style to columns
@ltiseanu
Merge pull request #387 from bitdefender/bf24
72bdd9c 
Option to change text and background color
@abutuza
readded language bar to scuderiaferraripages
f07dee3
ltiseanu and others added 30 commits December 10, 2024 12:06
@ltiseanu
Merge pull request #438 from bitdefender/DEX-21186
a8c0400 
DEX-21186 - Adding Zuora products mapping into excell on sharepoint
@iconstantin-bd
fixed mega menu error due to missconfigured query
25d1310
@iconstantin-bd
Merge pull request #439 from bitdefender/fix-mega-menu-error
52d3dbb 
fixed mega menu error due to missconfigured query
@iconstantin-bd
added missing bundle id
eb5e113
@iconstantin-bd
for ro domain, Vlaicu will be triggered by default
fda7619
@iconstantin-bd
Merge branch 'main' into dex-20840-vlaicu-implementation
97259b2
@iconstantin-bd
solved merge issues
8091af1
@abutuza
fixed styling issues found during block testing
5f0854f
@iconstantin-bd
changed empty string with constant
4bd5973
@iconstantin-bd
update the endpoint for zuoraConfig
c044bb6
@abutuza
Merge pull request #442 from bitdefender/DEX-21403
e4a59e7 
Issues with Image Column Component
@Matei-Iordache
add browser detection and update hero link for Firefox
b594702
@Matei-Iordache
Merge pull request #443 from bitdefender/DEX-21414
a1f6854 
add browser detection and update hero link for Firefox
@iconstantin-bd
Merge pull request #436 from bitdefender/dex-20840-vlaicu-implementation
0920c3a 
Dex 20840 vlaicu implementation
@iconstantin-bd
updated the id mappings to include secpassm
e9e6b43
@iconstantin-bd
added fix for other domains other than Vlaicu ones
2b7b4f8
@iconstantin-bd
Merge pull request #445 from bitdefender/dex-20840-vlaicu-implementation
0532b87 
updated the id mappings to include secpassm
@iconstantin-bd
prepared Vlaicu for deployment to production on all domains
ff01c4f
@iconstantin-bd
removed vlaicuFlag
6127468
@iconstantin-bd
updated the buy link parameters for Vlaicu
1de61a3
@iconstantin-bd
Merge pull request #450 from bitdefender/DEX-21261-fix-vlaicu-links
0fd4dda 
updated the buy link parameters for Vlaicu
@iconstantin-bd
Merge branch 'main' into dex-20840-vlaicu-implementation
ecd4fbb
@iconstantin-bd
made corner case for SOHO on de
096cdc6
@iconstantin-bd
Merge pull request #453 from bitdefender/dex-20840-vlaicu-implementation
8c233f6 
Dex 20840 vlaicu implementation
@iconstantin-bd
added correct ids
797f29f
@inastase
Merge pull request #455 from bitdefender/dex-20840-vlaicu-implementation
c7ac2dc 
added correct ids
@ltiseanu
update hero banner img
6c4b414
@ltiseanu
Merge branch 'main' of https://github.com/bitdefender/www-websites in…
c2a8ea2 
…to hero-update
@ltiseanu
update
303ab9b
@ltiseanu
update
d964a51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ltiseanu @abutuza @iconstantin-bd @Andserbanbitdefender @enake @inastase @Matei-Iordache @imantescu