generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix experimentation plugin subtree #446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/plugins/experimentation'
…3075 git-subtree-dir: solutions/plugins/experimentation git-subtree-split: b033075156f6d832a387d60193dc669ea59921a4
…62896d 162896d Update README.md 06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (#10) git-subtree-dir: solutions/plugins/experimentation git-subtree-split: 162896dd4908cf5b5270477a9a367ccd649d4d7d
…034373 2034373 fix: pill does not show any results even if RUM endpoint contains data 53696f4 fix: RUM endpoint url returns empty results fee6692 Update README.md 46e6a48 Update README.md 4ff6246 fix: leaking heading styles into the pill 02617d2 fix: sanitize experiment and variant names for proper css class injection d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented git-subtree-dir: solutions/plugins/experimentation git-subtree-split: 20343736178b33c5aa7c4f9fcc3e1e8fab942c7b
# Conflicts: # solutions/plugins/experimentation/README.md # solutions/plugins/experimentation/src/index.js # solutions/plugins/experimentation/src/preview.css # solutions/plugins/experimentation/src/preview.js # solutions/scripts/scripts.js
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
andreibogdan
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Test URLs: