Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix experimentation plugin subtree #446

Merged
merged 27 commits into from
Jan 29, 2024
Merged

feat: fix experimentation plugin subtree #446

merged 27 commits into from
Jan 29, 2024

Conversation

vtsaplin
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Test URLs:

…3075

git-subtree-dir: solutions/plugins/experimentation
git-subtree-split: b033075156f6d832a387d60193dc669ea59921a4
…62896d

162896d Update README.md
06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (#10)

git-subtree-dir: solutions/plugins/experimentation
git-subtree-split: 162896dd4908cf5b5270477a9a367ccd649d4d7d
…034373

2034373 fix: pill does not show any results even if RUM endpoint contains data
53696f4 fix: RUM endpoint url returns empty results
fee6692 Update README.md
46e6a48 Update README.md
4ff6246 fix: leaking heading styles into the pill
02617d2 fix: sanitize experiment and variant names for proper css class injection
d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented

git-subtree-dir: solutions/plugins/experimentation
git-subtree-split: 20343736178b33c5aa7c4f9fcc3e1e8fab942c7b
# Conflicts:
#	solutions/plugins/experimentation/README.md
#	solutions/plugins/experimentation/src/index.js
#	solutions/plugins/experimentation/src/preview.css
#	solutions/plugins/experimentation/src/preview.js
#	solutions/scripts/scripts.js
Copy link

aem-code-sync bot commented Jan 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 29, 2024

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@vtsaplin vtsaplin merged commit b83e72b into main Jan 29, 2024
3 checks passed
@vtsaplin vtsaplin deleted the experimentation branch January 29, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants