fix: svgs not getting rendered inside blocks #396
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
| const ul = document.createElement('ul'); | ||
| [...block.children].forEach((row) => { | ||
| const li = document.createElement('li'); | ||
| li.innerHTML = row.innerHTML; | ||
| Array.from(row.children).forEach((child) => li.appendChild(child)); |
There was a problem hiding this comment.
this is great, this solves the issue; so in conclusion we only need to call the decorateIcons() function just 1 time, right ( the the project level, in the scripts.js file ) ? also we have those remaining places that is also reproducing there, so they need fixes also ( I have updated https://svg-issue-fix--bitdefender--hlxsites.hlx.page/drafts/vlad/icons by adding the quotes carousel, and it's happening there ):
|
@ext-vradulescu-bf - I checked the link https://main--bitdefender--hlxsites.hlx.page/drafts/vlad/icons and could not spot any issue. Can you give me a hint for what I should look for?
|
issue: #395
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: