Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrict updates of links to the one with empty link #366

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

nicolasbarbe
Copy link
Collaborator

@nicolasbarbe nicolasbarbe commented Sep 27, 2023

Update button links only if their value is 'http://'

It allows to mix buttons with static links defined by the user in the word document and links (with http://) that will be automatically updated based on the chosen plan

Fix #365

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 27, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 27, 2023

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nicolasbarbe nicolasbarbe merged commit 8081a14 into main Sep 29, 2023
2 of 3 checks passed
@nicolasbarbe nicolasbarbe deleted the fix-button-url branch September 29, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homepage: Learn about wrong link
2 participants